From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752103AbbETHym (ORCPT ); Wed, 20 May 2015 03:54:42 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49046 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751849AbbETHyl (ORCPT ); Wed, 20 May 2015 03:54:41 -0400 Date: Wed, 20 May 2015 09:54:37 +0200 From: Jean Delvare To: Sudip Mukherjee Cc: Greg KH , Dan Carpenter , One Thousand Gnomes , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 WIP 1/5] parport: add device-model to parport subsystem Message-ID: <20150520095437.5966713b@endymion.delvare> In-Reply-To: <1430907377-17147-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1430907377-17147-1-git-send-email-sudipm.mukherjee@gmail.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 May 2015 15:46:13 +0530, Sudip Mukherjee wrote: > parport subsystem starts using the device-model. drivers using the > device-model has to define probe and should register the device with > parport with parport_register_dev_model() > > Signed-off-by: Sudip Mukherjee > --- Just one think I noticed while reviewing the i2c-parport patches: > +struct pardevice * > +parport_register_dev_model(struct parport *port, const char *name, > + struct pardev_cb *par_dev_cb, int cnt) par_dev_cb isn't modified by this function so it should be const. Also I don't much like the name "cnt", as the value is not a count, it's an index or identifier. What about "id"? -- Jean Delvare SUSE L3 Support