Re: [RFC v1 15/25] genirq: Kill the first parameter 'irq' of irq_flow_handler_t

Jiang Liu
2015-05-20T15:33:15Z

On 2015/5/20 23:28, Thomas Gleixner wrote:
> On Wed, 20 May 2015, Jiang Liu wrote:
>> -static void locomo_handler(unsigned int irq, struct irq_desc *desc)
>> +static void locomo_handler(struct irq_desc *desc)
>> {
>> struct locomo *lchip = irq_desc_get_chip_data(desc);
>> + unsigned int irq;
>> int req, i;
>
> That leaves irq unitialized ....
That should be OK, 'irq' here is just a local variable.
Actually it may be changed as:
if (req) {
/* generate the next interrupt(s) */
- irq = lchip->irq_base;
+ unsigned int irq = lchip->irq_base;
for (i = 0; i <= 3; i++, irq++) {
if (req & (0x0100 << i)) {
generic_handle_irq(irq);
}

}
}

>
> Thanks,
>
> tglx
>