Re: [RFC v1 10/25] sh: intc: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc

Thomas Gleixner
2015-05-20T15:12:39Z

On Wed, 20 May 2015, Jiang Liu wrote:

> Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc while we
> already have a pointer to corresponding irq_desc.
>
> Also replace generic_handle_irq with generic_handle_irq_desc() to avoid
> looking up irq_desc again.
>
> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
> ---
> drivers/sh/intc/core.c | 2 +-
> drivers/sh/intc/virq.c | 14 ++++++++------
> 2 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/sh/intc/core.c b/drivers/sh/intc/core.c
> index 81f22980b2de..e4ca964ca840 100644
> --- a/drivers/sh/intc/core.c
> +++ b/drivers/sh/intc/core.c
> @@ -67,7 +67,7 @@ void intc_set_prio_level(unsigned int irq, unsigned int level)
>
> static void intc_redirect_irq(unsigned int irq, struct irq_desc *desc)
> {
> - generic_handle_irq((unsigned int)irq_get_handler_data(irq));
> + generic_handle_irq_desc(irq, desc);

This looks wrong. It's a redirector of irq to some other irq.

redir_irq = (unsigned int)irq_get_handler_data(irq);

which should be:

redir_irq = (unsigned int)irq_desc_get_irq_handler_data(desc);

And redir_irq is certainly not the same as irq. So this wants a
conversion to irq_desc_get_irq_handler_data() first. That makes the
irq argument unused.

Thanks,

tglx