Re: [RFC v1 25/25] genirq: Kill the first parameter 'irq' of irq_flow_handler_t

Thomas Gleixner
2015-05-20T15:40:47Z

On Wed, 20 May 2015, Jiang Liu wrote:
> /* Chained IRQ handler for IPU error interrupt */
> -static void ipu_irq_err(unsigned int irq, struct irq_desc *desc)
> +static void ipu_irq_err(struct irq_desc *desc)
> {
> + unsigned int irq = irq_desc_to_irq(desc);

Why initializing? It's overwritten in the loop.

> /* Chained IRQ handler for IPU function interrupt */
> -static void ipu_irq_fn(unsigned int irq, struct irq_desc *desc)
> +static void ipu_irq_fn(struct irq_desc *desc)
> {
> + unsigned int irq = irq_desc_to_irq(desc);

Ditto.

Thanks,

tglx