From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
David Airlie <airlied@linux.ie>,
Daniel Stone <daniels@collabora.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: drop drm_property_unreference_blob_locked()
Date: Wed, 20 May 2015 20:50:09 +0900 [thread overview]
Message-ID: <20150520115009.GB1346@swordfish> (raw)
In-Reply-To: <87wq03k9mg.fsf@intel.com>
On (05/20/15 10:09), Jani Nikula wrote:
> > drm_property_unreference_blob_locked() is static and unused,
> > drop it.
>
> http://mid.gmane.org/CAPj87rMPtafeYNzgXoP+fx0dAqhwaD7kdnJgqb_vdbPtiOrXPg@mail.gmail.com
>
oh, ok. thanks.
-ss
> >
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > ---
> > drivers/gpu/drm/drm_crtc.c | 19 -------------------
> > 1 file changed, 19 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> > index 4059f06..6e60f71 100644
> > --- a/drivers/gpu/drm/drm_crtc.c
> > +++ b/drivers/gpu/drm/drm_crtc.c
> > @@ -4313,25 +4313,6 @@ void drm_property_unreference_blob(struct drm_property_blob *blob)
> > EXPORT_SYMBOL(drm_property_unreference_blob);
> >
> > /**
> > - * drm_property_unreference_blob_locked - Unreference a blob property with blob_lock held
> > - *
> > - * Drop a reference on a blob property. May free the object. This must be
> > - * called with blob_lock held.
> > - *
> > - * @param dev Device the blob was created on
> > - * @param blob Pointer to blob property
> > - */
> > -static void drm_property_unreference_blob_locked(struct drm_property_blob *blob)
> > -{
> > - if (!blob)
> > - return;
> > -
> > - DRM_DEBUG("%p: blob ID: %d (%d)\n", blob, blob->base.id, atomic_read(&blob->refcount.refcount));
> > -
> > - kref_put(&blob->refcount, drm_property_free_blob);
> > -}
> > -
> > -/**
> > * drm_property_reference_blob - Take a reference on an existing property
> > *
> > * Take a new reference on an existing blob property.
> > --
> > 2.4.1.168.g1ea28e1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Jani Nikula, Intel Open Source Technology Center
>
prev parent reply other threads:[~2015-05-20 11:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 11:38 [PATCH] drm: drop drm_property_unreference_blob_locked() Sergey Senozhatsky
2015-05-20 7:09 ` Jani Nikula
2015-05-20 11:50 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520115009.GB1346@swordfish \
--to=sergey.senozhatsky@gmail.com \
--cc=airlied@linux.ie \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox