From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753988AbbETOzZ (ORCPT ); Wed, 20 May 2015 10:55:25 -0400 Received: from m50-138.163.com ([123.125.50.138]:41174 "EHLO m50-138.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753297AbbETOzV (ORCPT ); Wed, 20 May 2015 10:55:21 -0400 Date: Wed, 20 May 2015 14:54:16 +0000 From: Geliang Tang To: Ian Abbott , hsweeten@visionengravers.com, gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, geliangtang@163.com Subject: [PATCH v2] staging: comedi: fix coding style issues Message-ID: <20150520145416.GA1891@localhost> References: <1431749763-2378-1-git-send-email-geliangtang@163.com> <5559CEE5.8040102@mev.co.uk> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="LZvS9be/3tNcYl/X" Content-Disposition: inline In-Reply-To: <5559CEE5.8040102@mev.co.uk> User-Agent: Mutt/1.5.23 (2014-03-12) X-CM-TRANSID: C9GowAA326kYoFxVOANUAg--.1387S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZrWxtF1rtw4fGFykAF1rtFb_yoW8ZrWxpr 4Uta4Y9rs0ga17u3ZrZr4UZFy5Wan3tay8ury3u3s8ZFnIvF9agFW5Kay293W5JryrAay2 y3W2gry7ua1Y9F7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jYyIUUUUUU= X-Originating-IP: [116.77.149.26] X-CM-SenderInfo: 5jhoxtpqjwt0rj6rljoofrz/1tbiJRsAmVUL4oGgyQAAsz Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --LZvS9be/3tNcYl/X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 18, 2015 at 12:37:09PM +0100, Ian Abbott wrote: > On 16/05/15 05:16, Geliang Tang wrote: > >1) Fixed an error found by checkpatch.pl. > > ERROR: space required after that ',' (ctx:VxV) > > ./drivers/ni_mio_common.c:3764 > >2) Changed "register 0x%x" to "register=0x%x" to keep the consistency > > of this file. > >3) The kernel version is next-20150515, 4.1.0-rc3. > > You shouldn't mention point 3 in the commit message as it will look a bit > strange when it ends up in the commit log. If you need to mention that, it > should go after the commit message, separated from the patch by a "---" line > like this: > > Body of commit message goes here. > > Signed off by and Cc lines go here. > --- > Additional patch commentary goes here. > --- > Actual patch goes here. > > Git will ignore the additional commentary when the patch is applied. > > > > >Signed-off-by: Geliang Tang > >--- > > drivers/staging/comedi/drivers/ni_mio_common.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > >diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c > >index 9dfd4e6..6cc304a 100644 > >--- a/drivers/staging/comedi/drivers/ni_mio_common.c > >+++ b/drivers/staging/comedi/drivers/ni_mio_common.c > >@@ -3761,7 +3761,7 @@ static unsigned int ni_gpct_to_stc_register(struct comedi_device *dev, > > if (reg < ARRAY_SIZE(ni_gpct_to_stc_regmap)) { > > regmap = &ni_gpct_to_stc_regmap[reg]; > > } else { > >- dev_warn(dev->class_dev,"%s: unhandled register 0x%x\n", > >+ dev_warn(dev->class_dev, "%s: unhandled register=0x%x\n", > > __func__, reg); > > return 0; > > } > > > > Apart from that niggle, the patch looks good! > > Reviewed-by: Ian Abbott > > -- > -=( Ian Abbott @ MEV Ltd. E-mail: )=- > -=( Web: http://www.mev.co.uk/ )=- Thank you for your review. I revised the patch as you suggested. Here it is. --LZvS9be/3tNcYl/X Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-staging-comedi-fix-coding-style-issues.patch" >>From d864f6af18a44031a241e10e64d98f9e6b8c0660 Mon Sep 17 00:00:00 2001 From: Geliang Tang Date: Wed, 20 May 2015 14:26:13 +0000 Subject: [PATCH v2] staging: comedi: fix coding style issues 1) Fixed an error found by checkpatch.pl. ERROR: space required after that ',' (ctx:VxV) ./drivers/ni_mio_common.c:3764 2) Changed "register 0x%x" to "register=0x%x" to keep the consistency of this file. Signed-off-by: Geliang Tang Reviewed-by: Ian Abbott --- Changes in v2: - remove the kernel version in the commit message. --- drivers/staging/comedi/drivers/ni_mio_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c index 9dfd4e6..6cc304a 100644 --- a/drivers/staging/comedi/drivers/ni_mio_common.c +++ b/drivers/staging/comedi/drivers/ni_mio_common.c @@ -3761,7 +3761,7 @@ static unsigned int ni_gpct_to_stc_register(struct comedi_device *dev, if (reg < ARRAY_SIZE(ni_gpct_to_stc_regmap)) { regmap = &ni_gpct_to_stc_regmap[reg]; } else { - dev_warn(dev->class_dev,"%s: unhandled register 0x%x\n", + dev_warn(dev->class_dev, "%s: unhandled register=0x%x\n", __func__, reg); return 0; } -- 2.3.4 --LZvS9be/3tNcYl/X--