From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Tim Waugh <tim@cyberelk.net>, Jean Delvare <jdelvare@suse.de>,
Willy Tarreau <willy@meta-x.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH 4/6] i2c-parport: use new parport device model
Date: Wed, 20 May 2015 22:44:52 +0530 [thread overview]
Message-ID: <20150520171452.GA9069@sudip-PC> (raw)
In-Reply-To: <20150520154907.GB2001@katana>
On Wed, May 20, 2015 at 05:49:07PM +0200, Wolfram Sang wrote:
> On Wed, May 20, 2015 at 08:57:00PM +0530, Sudip Mukherjee wrote:
> > Modify i2c-parport driver to use the new parallel port device model.
> >
> > Tested-by: Jean Delvare <jdelvare@suse.de>
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
>
> In general:
>
> Acked-by: Wolfram Sang <wsa@the-dreams.de>
>
> > static struct parport_driver i2c_parport_driver = {
> > - .name = "i2c-parport",
> > - .attach = i2c_parport_attach,
> > - .detach = i2c_parport_detach,
> > + .name = "i2c-parport",
> > + .match_port = i2c_parport_attach,
> > + .detach = i2c_parport_detach,
> > + .devmodel = true,
>
> Minor nit: I prefer to not use tabs but a single space after the struct
> member names. Less hazzle in the future and still readable IMO.
It was having space originally. I changed that into tab as it was
looking good with them as aligned.
I will wait today for some more review and send v2 tomorrow with this
chanage.
regards
sudip
>
next prev parent reply other threads:[~2015-05-20 17:15 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 15:26 [PATCH 0/6] use devicemodel with parport Sudip Mukherjee
2015-05-20 15:26 ` [PATCH 1/6] parport: add device-model to parport subsystem Sudip Mukherjee
2015-05-20 15:26 ` [PATCH 2/6] staging: panel: use new parport device model Sudip Mukherjee
2015-05-20 15:26 ` [PATCH 3/6] i2c-parport: define ports to connect Sudip Mukherjee
2015-05-20 15:46 ` Wolfram Sang
2015-05-20 15:27 ` [PATCH 4/6] i2c-parport: use new parport device model Sudip Mukherjee
2015-05-20 15:49 ` Wolfram Sang
2015-05-20 17:14 ` Sudip Mukherjee [this message]
2015-05-20 17:35 ` Wolfram Sang
2015-05-20 17:59 ` Jean Delvare
2015-05-21 1:02 ` [RFC PATCH] checkpatch: check for 2 or more spaces around assignment of a declaration Joe Perches
2015-05-21 5:48 ` Willy Tarreau
2015-05-21 6:16 ` [PATCH v2 4/6] i2c-parport: use new parport device model Sudip Mukherjee
2015-05-20 15:27 ` [PATCH 5/6] paride: " Sudip Mukherjee
2015-05-20 15:27 ` [PATCH 6/6] MAINTAINERS: maintain parport Sudip Mukherjee
2015-05-20 15:46 ` Richard Weinberger
2015-05-20 16:28 ` Joe Perches
2015-05-20 17:31 ` Sudip Mukherjee
2015-05-20 16:33 ` One Thousand Gnomes
2015-05-20 20:36 ` Richard Weinberger
2015-05-21 5:59 ` Sudip Mukherjee
2015-05-21 5:51 ` Willy Tarreau
2015-05-21 6:09 ` Greg Kroah-Hartman
2015-05-31 22:05 ` [PATCH 0/6] use devicemodel with parport Greg Kroah-Hartman
2015-06-01 5:46 ` Sudip Mukherjee
2015-06-01 6:18 ` Greg Kroah-Hartman
2015-06-01 8:34 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520171452.GA9069@sudip-PC \
--to=sudipm.mukherjee@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@cyberelk.net \
--cc=willy@meta-x.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).