From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754866AbbETRPJ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 20 May 2015 13:15:09 -0400
Received: from mail-pa0-f46.google.com ([209.85.220.46]:33483 "EHLO
	mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753241AbbETRPH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 20 May 2015 13:15:07 -0400
Date: Wed, 20 May 2015 22:44:52 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Tim Waugh <tim@cyberelk.net>, Jean Delvare <jdelvare@suse.de>,
        Willy Tarreau <willy@meta-x.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alan Cox <gnomes@lxorguk.ukuu.org.uk>, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 4/6] i2c-parport: use new parport device model
Message-ID: <20150520171452.GA9069@sudip-PC>
References: <1432135622-8288-1-git-send-email-sudipm.mukherjee@gmail.com>
 <1432135622-8288-5-git-send-email-sudipm.mukherjee@gmail.com>
 <20150520154907.GB2001@katana>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150520154907.GB2001@katana>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, May 20, 2015 at 05:49:07PM +0200, Wolfram Sang wrote:
> On Wed, May 20, 2015 at 08:57:00PM +0530, Sudip Mukherjee wrote:
> > Modify i2c-parport driver to use the new parallel port device model.
> > 
> > Tested-by: Jean Delvare <jdelvare@suse.de>
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
> 
> In general:
> 
> Acked-by: Wolfram Sang <wsa@the-dreams.de>
> 
> >  static struct parport_driver i2c_parport_driver = {
> > -	.name	= "i2c-parport",
> > -	.attach	= i2c_parport_attach,
> > -	.detach	= i2c_parport_detach,
> > +	.name		= "i2c-parport",
> > +	.match_port	= i2c_parport_attach,
> > +	.detach		= i2c_parport_detach,
> > +	.devmodel	= true,
> 
> Minor nit: I prefer to not use tabs but a single space after the struct
> member names. Less hazzle in the future and still readable IMO.
It was having space originally. I changed that into tab as it was
looking good with them as aligned.
I will wait today for some more review and send v2 tomorrow with this
chanage.

regards
sudip
>