From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932154AbbETRfd (ORCPT ); Wed, 20 May 2015 13:35:33 -0400 Received: from sauhun.de ([89.238.76.85]:34746 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751818AbbETRfa (ORCPT ); Wed, 20 May 2015 13:35:30 -0400 Date: Wed, 20 May 2015 19:35:17 +0200 From: Wolfram Sang To: Sudip Mukherjee Cc: Tim Waugh , Jean Delvare , Willy Tarreau , Greg Kroah-Hartman , Alan Cox , linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH 4/6] i2c-parport: use new parport device model Message-ID: <20150520173516.GA1615@katana> References: <1432135622-8288-1-git-send-email-sudipm.mukherjee@gmail.com> <1432135622-8288-5-git-send-email-sudipm.mukherjee@gmail.com> <20150520154907.GB2001@katana> <20150520171452.GA9069@sudip-PC> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7" Content-Disposition: inline In-Reply-To: <20150520171452.GA9069@sudip-PC> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --1yeeQ81UyVL57Vl7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > > static struct parport_driver i2c_parport_driver =3D { > > > - .name =3D "i2c-parport", > > > - .attach =3D i2c_parport_attach, > > > - .detach =3D i2c_parport_detach, > > > + .name =3D "i2c-parport", > > > + .match_port =3D i2c_parport_attach, > > > + .detach =3D i2c_parport_detach, > > > + .devmodel =3D true, > >=20 > > Minor nit: I prefer to not use tabs but a single space after the struct > > member names. Less hazzle in the future and still readable IMO. > It was having space originally. I changed that into tab as it was > looking good with them as aligned. > I will wait today for some more review and send v2 tomorrow with this > chanage. Thanks. Just to make sure: Keep it one space only, no alignment. --1yeeQ81UyVL57Vl7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVXMXUAAoJEBQN5MwUoCm2LAkQAI3GD0CiKe4g10DwxbK1rY56 67IGo5eZYiaSotv4nxU1esXo/D4sAlX7ekBIJo9B7/86TmP6CZqiOfkPziT7jshn 3XYc/v2sYixyNBr3c6cLtfmaQuUTgxTHcEwgoBo07DV5cuSFsLvrNympRyGmuTJC +mehzBVGLUXFHyHODehx8bRNkZrFs8boKEJvFHG/VCJpOeSyVkcJdJk1cPYDJ+VP i0XXqYDiX58pbaO6gf5iM0VyVyuEtnarCvE3uYzJMarRL8OfxYvP0T+V5Ur+PMGk ocUSewuexL9Rt0nxaDQePCrpMB6MBffgTymTbZ7CmNtKTJEyUAFwAHPZsHBWE7hI PhNbBuddrht+UiVG2eKjz84CltqIcCMvJ4Oh9vbR7IEhh3d92XZ/f4z1GXZ6qH9+ O+e3JH2iXtDLR7MlTh46Y14Oomwpgu45HSaBTwDUBZxpvhuxY5A++igitXXBlOXG 1pwPrhaGFvF4PjIyq9zZcBZEJShmeeVfvshz4yi+o8yGdt5Oa/z8k1PZN3kURCqA +FvKdbAWGJraYXoS5ko9Vo2z4Znk4Gm7hmIXZodvfbY2D+O8OMvHDOmEB/T7cOzz NpJnzogfAbc06/vyhOYpsfungWoO9F3Rv6vHA6lQpM53OArPLB7uqRgDC14ONs+J w5Sbm6pW8r3Sk7EztQIO =kLCe -----END PGP SIGNATURE----- --1yeeQ81UyVL57Vl7--