From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932141AbbETR73 (ORCPT ); Wed, 20 May 2015 13:59:29 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39362 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754396AbbETR7X (ORCPT ); Wed, 20 May 2015 13:59:23 -0400 Date: Wed, 20 May 2015 19:59:18 +0200 From: Jean Delvare To: Sudip Mukherjee Cc: Wolfram Sang , Tim Waugh , Willy Tarreau , Greg Kroah-Hartman , Alan Cox , linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH 4/6] i2c-parport: use new parport device model Message-ID: <20150520195918.1c150979@endymion.delvare> In-Reply-To: <20150520171452.GA9069@sudip-PC> References: <1432135622-8288-1-git-send-email-sudipm.mukherjee@gmail.com> <1432135622-8288-5-git-send-email-sudipm.mukherjee@gmail.com> <20150520154907.GB2001@katana> <20150520171452.GA9069@sudip-PC> Organization: SUSE Linux X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 May 2015 22:44:52 +0530, Sudip Mukherjee wrote: > On Wed, May 20, 2015 at 05:49:07PM +0200, Wolfram Sang wrote: > > On Wed, May 20, 2015 at 08:57:00PM +0530, Sudip Mukherjee wrote: > > > static struct parport_driver i2c_parport_driver = { > > > - .name = "i2c-parport", > > > - .attach = i2c_parport_attach, > > > - .detach = i2c_parport_detach, > > > + .name = "i2c-parport", > > > + .match_port = i2c_parport_attach, > > > + .detach = i2c_parport_detach, > > > + .devmodel = true, > > > > Minor nit: I prefer to not use tabs but a single space after the struct > > member names. Less hazzle in the future and still readable IMO. > > It was having space originally. I changed that into tab as it was > looking good with them as aligned. As the driver maintainer, I am fine with both unaligned or tab-aligned. Space-aligned as I did originally was not a good idea, I admit. -- Jean Delvare SUSE L3 Support