From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754744AbbEUCBF (ORCPT ); Wed, 20 May 2015 22:01:05 -0400 Received: from relay2.sgi.com ([192.48.180.65]:47705 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753717AbbEUCBB (ORCPT ); Wed, 20 May 2015 22:01:01 -0400 X-Greylist: delayed 575 seconds by postgrey-1.27 at vger.kernel.org; Wed, 20 May 2015 22:01:01 EDT Date: Wed, 20 May 2015 20:51:09 -0500 From: Dimitri Sivanich To: Colin King Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] sgi-gru: fix null pointer dereference on failed kzalloc Message-ID: <20150521015109.GA31898@sgi.com> References: <1431505186-22628-1-git-send-email-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431505186-22628-1-git-send-email-colin.king@canonical.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Dimitri Sivanich On Wed, May 13, 2015 at 09:19:46AM +0100, Colin King wrote: > From: Colin Ian King > > static analysis from smatch found a potential null dereference: > > drivers/misc/sgi-gru/grutlbpurge.c:320 gru_register_mmu_notifier() error: > potential null dereference 'gms'. (kzalloc returns null) > > bail out with -ENOMEM rather than falling through and printing a debug > message that trips a null dereference. > > Signed-off-by: Colin Ian King > --- > drivers/misc/sgi-gru/grutlbpurge.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/misc/sgi-gru/grutlbpurge.c b/drivers/misc/sgi-gru/grutlbpurge.c > index 2129274..1239800 100644 > --- a/drivers/misc/sgi-gru/grutlbpurge.c > +++ b/drivers/misc/sgi-gru/grutlbpurge.c > @@ -315,6 +315,8 @@ struct gru_mm_struct *gru_register_mmu_notifier(void) > err = __mmu_notifier_register(&gms->ms_notifier, current->mm); > if (err) > goto error; > + } else { > + return ERR_PTR(-ENOMEM); > } > } > gru_dbg(grudev, "gms %p, refcnt %d\n", gms, > -- > 2.1.4