From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754927AbbEUCHV (ORCPT ); Wed, 20 May 2015 22:07:21 -0400 Received: from mail-ig0-f177.google.com ([209.85.213.177]:36364 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753636AbbEUCHR (ORCPT ); Wed, 20 May 2015 22:07:17 -0400 Date: Wed, 20 May 2015 21:07:09 -0500 From: Michael Welling To: Mark Brown Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-next@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] spi: omap2-mcspi: Fix native cs with new set_cs Message-ID: <20150521020709.GA14258@deathray> References: <1431452337-19280-1-git-send-email-mwelling@ieee.org> <20150512191758.GX3066@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150512191758.GX3066@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 12, 2015 at 08:17:58PM +0100, Mark Brown wrote: > On Tue, May 12, 2015 at 12:38:57PM -0500, Michael Welling wrote: > > GPIO chip select patch series appears to have broken the native chip select > > support. This patch pulls the manual native chip select toggling out of > > the transfer_one routine and adds a set_cs routine. > > Applied, thanks It appears that in haste, this fix for the native cs support broke the GPIO chip select support that I was originally shooting for. [ 2.653658] mcp23s08 spi1.1: TXS timed out [ 2.657961] mcp23s08 spi1.1: SPI transfer failed: -5 [ 2.663305] spi_master spi1: failed to transfer one message from queue [ 2.670172] mcp23s08 spi1.1: can't setup chip 64, --> -5 [ 2.675784] GPIO chip mcp23s08: gpiochip_unexport: status -19 My guess is that the set_cs needs to be called even when toggling as GPIO. How should I handle this?