Re: [PATCH 4/7] tracing: timer: Add deferrable flag to timer_start

Thomas Gleixner
2015-05-22T22:58:13Z

On Thu, 21 May 2015, Ingo Molnar wrote:
> * John Stultz <john.stultz@linaro.org> wrote:
> > - TP_PROTO(struct timer_list *timer, unsigned long expires),
> > + TP_PROTO(struct timer_list *timer,
> > + unsigned long expires,
>
> This isn't compat safe, should any tooling rely on this.

I can't see how that matters. The binary trace tells you from which
machine (32 or 64 bit) it comes. So the field size is available for
the tool. If the tool blindly applies the format string, it's hardly a
fault of the kernel. And there is no point to bloat 32bit tracing with
64bit entries just because some random tool might be stupid.

Just for the record: We have 539 'unsigned long' and 62 'long' event
fields in include/trace/events/.

Thanks,

tglx