From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jan Kara <jack@suse.cz>
Cc: Fabian Frederick <fabf@skynet.be>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] udf: fix udf_load_pvoldesc()
Date: Thu, 21 May 2015 18:04:59 +0300 [thread overview]
Message-ID: <20150521150459.GH4150@mwanda> (raw)
In-Reply-To: <20150521132156.GG27863@quack.suse.cz>
On Thu, May 21, 2015 at 03:21:56PM +0200, Jan Kara wrote:
> On Wed 20-05-15 11:13:15, Dan Carpenter wrote:
> > There are some missing braces here which means this function never
> > succeeds.
> >
> > Fixes: e9d4cf411f75 ('udf: improve error management in udf_CS0toUTF8()')
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Thanks for the patch. Added to my tree. Actually, the missing parenthesis
> don't cause any real issues since almost all volumes have volIdent and thus
> ret gets set to 0 in the previous if. But it's certainly good to fix.
Ah... I didn't read carefully. Thanks.
regards,
dan carpenter
prev parent reply other threads:[~2015-05-21 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 8:13 [patch] udf: fix udf_load_pvoldesc() Dan Carpenter
2015-05-21 13:21 ` Jan Kara
2015-05-21 15:04 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150521150459.GH4150@mwanda \
--to=dan.carpenter@oracle.com \
--cc=fabf@skynet.be \
--cc=jack@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox