public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: dinguyen@opensource.altera.com
Cc: mturquette@linaro.org, dinh.linux@gmail.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCHv4 2/2] clk: socfpga: add a clock driver for the Arria 10 platform
Date: Thu, 21 May 2015 15:17:33 -0700	[thread overview]
Message-ID: <20150521221733.GB1885@codeaurora.org> (raw)
In-Reply-To: <1432092162-8889-3-git-send-email-dinguyen@opensource.altera.com>

On 05/19, dinguyen@opensource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
> 
> The clocks on the Arria 10 platform is a bit different than the Cyclone/Arria 5
> platform that it should just have it's own driver.
> 
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> ---

Applied to clk-next. One note below.

> +	of_property_read_string(node, "clock-output-names", &clk_name);
> +
> +	init.name = clk_name;
> +	init.ops = ops;
> +	init.flags = 0;
> +	while (i < SOCFPGA_MAX_PARENTS && (parent_name[i] =
> +			of_clk_get_parent_name(node, i)) != NULL)
> +		i++;

Perhaps this should be a generic clk framework helper.
	
	int of_clk_parent_something(node, array, size)

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

      reply	other threads:[~2015-05-21 22:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-20  3:22 [PATCHv4 0/2] clk: socfpga: Add clock driver for Arria10 dinguyen
2015-05-20  3:22 ` [PATCHv4 1/2] clk: socfpga: update clk.h so for Arria10 platform to use dinguyen
2015-05-20  3:22 ` [PATCHv4 2/2] clk: socfpga: add a clock driver for the Arria 10 platform dinguyen
2015-05-21 22:17   ` Stephen Boyd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150521221733.GB1885@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=dinguyen@opensource.altera.com \
    --cc=dinh.linux@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox