From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756870AbbEUWRk (ORCPT ); Thu, 21 May 2015 18:17:40 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51917 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756206AbbEUWRf (ORCPT ); Thu, 21 May 2015 18:17:35 -0400 Date: Thu, 21 May 2015 15:17:33 -0700 From: Stephen Boyd To: dinguyen@opensource.altera.com Cc: mturquette@linaro.org, dinh.linux@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 2/2] clk: socfpga: add a clock driver for the Arria 10 platform Message-ID: <20150521221733.GB1885@codeaurora.org> References: <1432092162-8889-1-git-send-email-dinguyen@opensource.altera.com> <1432092162-8889-3-git-send-email-dinguyen@opensource.altera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432092162-8889-3-git-send-email-dinguyen@opensource.altera.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/19, dinguyen@opensource.altera.com wrote: > From: Dinh Nguyen > > The clocks on the Arria 10 platform is a bit different than the Cyclone/Arria 5 > platform that it should just have it's own driver. > > Signed-off-by: Dinh Nguyen > --- Applied to clk-next. One note below. > + of_property_read_string(node, "clock-output-names", &clk_name); > + > + init.name = clk_name; > + init.ops = ops; > + init.flags = 0; > + while (i < SOCFPGA_MAX_PARENTS && (parent_name[i] = > + of_clk_get_parent_name(node, i)) != NULL) > + i++; Perhaps this should be a generic clk framework helper. int of_clk_parent_something(node, array, size) -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project