From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755442AbbEVCRi (ORCPT ); Thu, 21 May 2015 22:17:38 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:34365 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754442AbbEVCRf (ORCPT ); Thu, 21 May 2015 22:17:35 -0400 Date: Fri, 22 May 2015 07:47:30 +0530 From: Viresh Kumar To: Shailendra Verma Cc: "Rafael J. Wysocki" , Kukjin Kim , Krzysztof Kozlowski , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpufreq:exynos-cpufreq - Fix for memory leak in case SOC name does not match. Message-ID: <20150522021730.GA7730@linux> References: <1432232981-3917-1-git-send-email-shailendra.capricorn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432232981-3917-1-git-send-email-shailendra.capricorn@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21-05-15, 23:59, Shailendra Verma wrote: > During probe free the memory allocated to "exynos_info" in case of unknown > SOC type. > > Signed-off-by: Shailendra Verma > --- > drivers/cpufreq/exynos-cpufreq.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c > index 82d2fbb..b77923a 100644 > --- a/drivers/cpufreq/exynos-cpufreq.c > +++ b/drivers/cpufreq/exynos-cpufreq.c > @@ -182,6 +182,7 @@ static int exynos_cpufreq_probe(struct platform_device *pdev) > ret = exynos5250_cpufreq_init(exynos_info); > } else { > pr_err("%s: Unknown SoC type\n", __func__); > + kfree(exynos_info); > return -ENODEV; > } There is no point replicating this stuff. Use labels like: err_vdd_arm to get this done. But you also need to make sure the right error gets propagated. -- viresh