From: David Cohen <david.a.cohen@linux.intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
qiuxu.zhuo@intel.com
Subject: Re: [PATCH v2 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall
Date: Thu, 21 May 2015 20:09:54 -0700 [thread overview]
Message-ID: <20150522030954.GA28433@psi-dev26.jf.intel.com> (raw)
In-Reply-To: <1432260425-2350-1-git-send-email-baolu.lu@linux.intel.com>
Hi,
On Fri, May 22, 2015 at 10:07:05AM +0800, Lu Baolu wrote:
> Many drivers and modules depend on ULPI bus registeration to
> register ULPI interfaces and drivers. It's more appropriate
> to register ULPI bus in subsys_initcall instead of module_init.
>
> Kernel panic has been reported with some kind of kernel config.
Even though I agree subsys_initcall is better to register ulpi bus, it's
still no excuse to have kernel panic. What about ULPI bus being compiled
as module?
IMHO this is avoiding the proper kernel panic fix which should be
failing gracefully (or defer probe) from tusb1210 driver.
Br, David
next prev parent reply other threads:[~2015-05-22 3:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 2:07 [PATCH v2 1/1] usb: ulpi: ulpi_init should be executed in subsys_initcall Lu Baolu
2015-05-22 3:09 ` David Cohen [this message]
2015-05-22 3:11 ` David Cohen
2015-05-22 6:46 ` Lu, Baolu
2015-05-22 7:50 ` Lu, Baolu
2015-05-22 16:12 ` David Cohen
2015-05-22 10:07 ` Heikki Krogerus
2015-05-24 16:25 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150522030954.GA28433@psi-dev26.jf.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=qiuxu.zhuo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox