From: Brian Norris <computersforpeace@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Michal Suchanek" <hramrach@gmail.com>,
linux-sunxi <linux-sunxi@googlegroups.com>,
"Marek Vasut" <marex@denx.de>, "Rafał Miłecki" <zajec5@gmail.com>,
"Alison Chaiken" <alison_chaiken@mentor.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Bean Huo 霍斌斌 (beanhuo)" <beanhuo@micron.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
linux-mtd@lists.infradead.org,
linux-spi <linux-spi@vger.kernel.org>
Subject: Re: [PATCH 2/3] MTD: spi-nor: check for short writes in spi_nor_write.
Date: Fri, 22 May 2015 00:25:05 -0700 [thread overview]
Message-ID: <20150522072505.GE23718@brian-ubuntu> (raw)
In-Reply-To: <20150522071727.GD23718@brian-ubuntu>
(trimming CC a little this time, though it's still a bit large)
On Fri, May 22, 2015 at 12:17:27AM -0700, Brian Norris wrote:
> Admittedly, as he's using an out-of-tree driver, I'm not
> sure I know exactly what failure modes he is hitting yet.
Sorry, I realized I misread here. He's using spi-sunxi. Given that...
... is this code even valid?
static int sun6i_spi_transfer_one(struct spi_master *master,
struct spi_device *spi,
struct spi_transfer *tfr)
{
...
/* We don't support transfer larger than the FIFO */
if (tfr->len > SUN6I_FIFO_DEPTH)
return -EINVAL;
Seems like it should be looping over the transfer in multiple chunks
instead.
Brian
next prev parent reply other threads:[~2015-05-22 7:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1430403750.git.hramrach@gmail.com>
[not found] ` <3b0c112672f364452e80c333048161eaffb655db.1430403750.git.hramrach@gmail.com>
2015-04-30 14:58 ` [linux-sunxi] [PATCH 3/3] MTD: m25p80: Add option to limit SPI transfer size Julian Calaby
2015-05-20 23:27 ` Brian Norris
2015-04-30 16:30 ` [PATCH 0/3] Using SPI NOR flah on sunxi Thomas.Betker
2015-04-30 16:56 ` Michal Suchanek
2015-04-30 18:34 ` Marek Vasut
2015-05-20 23:54 ` Brian Norris
[not found] ` <55132b4496e7fe73f949186c0f140f3e4fd4e2c7.1430403750.git.hramrach@gmail.com>
2015-04-30 18:43 ` [PATCH 1/3] MTD: m25p80: fix write return value Marek Vasut
2015-04-30 21:37 ` Michal Suchanek
[not found] ` <jwv4mnwfppf.fsf-monnier+gmane.comp.hardware.netbook.arm.sunxi@gnu.org>
2015-05-04 10:32 ` [linux-sunxi] Re: [PATCH 0/3] Using SPI NOR flah on sunxi Michal Suchanek
[not found] ` <50c40ef17ab6566f35ef5a4426bf23567f896db7.1430403750.git.hramrach@gmail.com>
2015-05-20 23:38 ` [PATCH 2/3] MTD: spi-nor: check for short writes in spi_nor_write Brian Norris
2015-05-21 8:39 ` Michal Suchanek
2015-05-21 10:28 ` Mark Brown
2015-05-22 7:17 ` Brian Norris
2015-05-22 7:25 ` Brian Norris [this message]
2015-05-22 9:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150522072505.GE23718@brian-ubuntu \
--to=computersforpeace@gmail.com \
--cc=alison_chaiken@mentor.com \
--cc=beanhuo@micron.com \
--cc=broonie@kernel.org \
--cc=hramrach@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=marex@denx.de \
--cc=mika.westerberg@linux.intel.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox