From: Jonathan Corbet <corbet@lwn.net>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] Docs: SubmittingPatches: Clarify convention for git commit references
Date: Fri, 22 May 2015 09:36:08 -0600 [thread overview]
Message-ID: <20150522093608.420edaf7@lwn.net> (raw)
In-Reply-To: <20150521155954.9522.33952.stgit@bhelgaas-glaptop2.roam.corp.google.com>
On Thu, 21 May 2015 10:59:54 -0500
Bjorn Helgaas <bhelgaas@google.com> wrote:
> Clarify the convention for commit references in changelogs so it matches
> what checkpatch suggests; see d311cd44545f ("checkpatch: add test for
> commit id formatting style in commit log").
>
> I chose a different example to make the ("") around the description more
> obvious.
In general the change is fine, and I agree with the change in example.
You took out the reasons for use of 12 characters, though, and I'd rather
not do that. People like to know why a particular practice makes
sense... Can I get a version that preserves that text?
Thanks,
jon
prev parent reply other threads:[~2015-05-22 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 15:59 [PATCH] Docs: SubmittingPatches: Clarify convention for git commit references Bjorn Helgaas
2015-05-21 16:19 ` Joe Perches
2015-05-21 16:44 ` Bjorn Helgaas
2015-05-21 17:04 ` Joe Perches
2015-05-21 19:03 ` Josh Stone
2015-05-22 15:36 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150522093608.420edaf7@lwn.net \
--to=corbet@lwn.net \
--cc=bhelgaas@google.com \
--cc=joe@perches.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).