Re: [PATCH v4 00/13] staging: lustre: lnet: code cleanups

Michael Shuey
2015-05-23T12:09:57Z

Hm, that's unfortunate - but my own fault for lack of proper
etiquette. I'll give this a week or two to settle, and build up
patches against other parts of lustre in the meantime.

BTW, you keep mentioning a v5 that I sent. Where is that, exactly?
The last round of patches I sent I've kept labeled as "PATCH v4", and
I only hit git send-email once. Could you forward me something from
this v5 series, so I could see if anything is amiss on my end?
--
Mike Shuey

On Sat, May 23, 2015 at 6:14 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We would have applied the v3 patchset but now I don't know because we're
> up to v5. We can't apply v5 because there are problems with it. No
> one responded to v3 so Greg still might apply it or he might find these
> email threads too scrambled and delete everything and ask for a resend.
>
> It's pretty messed up so just wait for Greg to get to it before sending
> more patches?
>
> Basically you should only send patches which you assume will be applied.
> If no one responds after 3 days then probably that means everyone from
> the peanut gallery (Me, Sudip, Joe, the lustre devs), we don't have an
> issue. Then Greg does the last review (2-3 weeks later perhaps). But
> if it makes it past all the other reviews then generally Greg also will
> be ok with it.
>
> Greg applies patches in first come, first applied order. If they don't
> apply then you have to redo it. He doesn't invest a lot of time into
> figuring out why. So you have to coordinate with the other devs, it's
> up to you how you do that.
>
> regards,
> dan carpenter
>