Re: [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl fixes

Joe Perches
2015-05-21T21:00:16Z

On Thu, 2015-05-21 at 15:50 -0400, Mike Shuey wrote:
> Fix many checkpatch.pl warnings.
[]
> diff --git a/drivers/staging/lustre/lnet/lnet/acceptor.c b/drivers/staging/lustre/lnet/lnet/acceptor.c
[]
> @@ -99,38 +99,42 @@ lnet_connect_console_error(int rc, lnet_nid_t peer_nid,
> switch (rc) {
> /* "normal" errors */
> case -ECONNREFUSED:
> - CNETERR("Connection to %s at host %pI4h on port %d was refused: check that Lustre is running on that node.\n",
> - libcfs_nid2str(peer_nid),
> - &peer_ip, peer_port);
> + CNETERR(
> + "Connection to %s at host %pI4h on port %d was refused: check that Lustre is running on that node.\n",
> + libcfs_nid2str(peer_nid), &peer_ip, peer_port);

These are not improvements and checkpatch messages aren't dicta.

Please don't convert code unless the conversion makes it better
for a human reader.

These don't.