From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964857AbbEVSJv (ORCPT ); Fri, 22 May 2015 14:09:51 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:41198 "EHLO e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964802AbbEVSJu (ORCPT ); Fri, 22 May 2015 14:09:50 -0400 Date: Fri, 22 May 2015 11:09:17 -0700 From: Sukadev Bhattiprolu To: Andi Kleen Cc: Jiri Olsa , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , mingo@redhat.com, Paul Mackerras , namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 2/4] perf: jevents: Program to convert JSON file to C style file Message-ID: <20150522180917.GA5471@us.ibm.com> References: <1432080130-6678-1-git-send-email-sukadev@linux.vnet.ibm.com> <1432080130-6678-3-git-send-email-sukadev@linux.vnet.ibm.com> <20150522145615.GA16473@krava.redhat.com> <20150522155822.GA15904@us.ibm.com> <20150522180110.GI7484@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150522180110.GI7484@tassilo.jf.intel.com> X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15052218-0013-0000-0000-00000B00785F Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andi Kleen [ak@linux.intel.com] wrote: | > pmu-events.c depends only on JSON files relevant to the arch perf is | > being built on and there could be several JSON files per arch. So it | > would complicate the Makefiles. | | Could just use a wildcard dependency on */$(ARCH)/*.json Sure, but shouldn't we allow JSON files to be in subdirs pmu-events/arch/x86/HSX/Haswell_core.json and this could go to arbitrary levels? | | Also it would be good to move the generated file into the object | directory. I tried it but it needs some more changes to the Makefiles. | | -Andi