Re: [PATCH v1] power: max17042_battery: add HEALTH and TEMP_* properties support

Sebastian Reichel
2015-05-23T18:10:30Z

[-- Attachment #1: Type: text/plain, Size: 791 bytes --]

Hi,

On Tue, May 05, 2015 at 05:10:32AM +0530, Ramakrishna Pallala wrote:
> This patch adds the support for following battery properties
> to max17042 fuel gauge driver.
>
> POWER_SUPPLY_PROP_TEMP_ALERT_MIN
> POWER_SUPPLY_PROP_TEMP_ALERT_MAX
> POWER_SUPPLY_PROP_TEMP_MIN
> POWER_SUPPLY_PROP_TEMP_MAX
> POWER_SUPPLY_PROP_HEALTH
>
> Signed-off-by: Ramakrishna Pallala <ramakrishna.pallala@intel.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>

The patch does not work for me:

drivers/power/max17042_battery.c: In function ‘max17042_get_battery_health’:
drivers/power/max17042_battery.c:150:34: error: ‘MAX17042_VMAX_TOLERENCE’ undeclared (first use in this function)
if (vbatt > chip->pdata->vmax + MAX17042_VMAX_TOLERENCE) {

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]