RE: [PATCH v1] power: max17042_battery: add HEALTH and TEMP_* properties support

Pallala, Ramakrishna
2015-05-23T19:28:30Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1019 bytes --]

> Hi,
>
> On Tue, May 05, 2015 at 05:10:32AM +0530, Ramakrishna Pallala wrote:
> > This patch adds the support for following battery properties to
> > max17042 fuel gauge driver.
> >
> > POWER_SUPPLY_PROP_TEMP_ALERT_MIN
> > POWER_SUPPLY_PROP_TEMP_ALERT_MAX
> > POWER_SUPPLY_PROP_TEMP_MIN
> > POWER_SUPPLY_PROP_TEMP_MAX
> > POWER_SUPPLY_PROP_HEALTH
> >
> > Signed-off-by: Ramakrishna Pallala <ramakrishna.pallala@intel.com>
> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
>
> The patch does not work for me:
>
> drivers/power/max17042_battery.c: In function
> ‘max17042_get_battery_health’:
> drivers/power/max17042_battery.c:150:34: error:
> ‘MAX17042_VMAX_TOLERENCE’ undeclared (first use in this function)
> if (vbatt > chip->pdata->vmax + MAX17042_VMAX_TOLERENCE) {

My bad :( :(

I will fix it submit the patch v2

Thanks,
Ram
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥