From: Marek Vasut <marex@denx.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: stmpe-ts - enforce device tree only mode
Date: Sat, 23 May 2015 18:38:54 +0200 [thread overview]
Message-ID: <201505231838.54349.marex@denx.de> (raw)
In-Reply-To: <20150522225832.GA19831@dtor-ws>
On Saturday, May 23, 2015 at 12:58:32 AM, Dmitry Torokhov wrote:
> The STMPE MFD is only used with device tree configured systems (and STMPE
> MFD core depends on OF), so force the configuration to come from device
> tree only.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
Hi!
[...]
> @@ -351,14 +336,13 @@ static int stmpe_input_probe(struct platform_device
> *pdev) idev->name = STMPE_TS_NAME;
> idev->phys = STMPE_TS_NAME"/input0";
> idev->id.bustype = BUS_I2C;
> - idev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS);
> - idev->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH);
>
> idev->open = stmpe_ts_open;
> idev->close = stmpe_ts_close;
>
> input_set_drvdata(idev, ts);
>
> + input_set_capability(idev, EV_KEY, BTN_TOUCH);
Isn't this part of the patch dropping the EV_ABS evbit ?
> input_set_abs_params(idev, ABS_X, 0, XY_MASK, 0, 0);
> input_set_abs_params(idev, ABS_Y, 0, XY_MASK, 0, 0);
> input_set_abs_params(idev, ABS_PRESSURE, 0x0, 0xff, 0, 0);
[...]
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-05-23 16:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 22:58 [PATCH] Input: stmpe-ts - enforce device tree only mode Dmitry Torokhov
2015-05-23 10:59 ` Heiner Kallweit
2015-05-23 16:38 ` Marek Vasut [this message]
2015-05-23 16:41 ` Dmitry Torokhov
2015-05-23 21:29 ` Marek Vasut
2015-05-26 8:42 ` Lee Jones
2015-06-01 14:48 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201505231838.54349.marex@denx.de \
--to=marex@denx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox