From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758121AbbEWVaA (ORCPT <rfc822;w@1wt.eu>);
	Sat, 23 May 2015 17:30:00 -0400
Received: from mail-out.m-online.net ([212.18.0.10]:59214 "EHLO
	mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758088AbbEWV35 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 23 May 2015 17:29:57 -0400
X-Auth-Info: 00fW8NOIWEyE/70sbcoDbIX1dKYTCMLz5CpvH+JXuaQ=
From: Marek Vasut <marex@denx.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] Input: stmpe-ts - enforce device tree only mode
Date: Sat, 23 May 2015 23:29:53 +0200
User-Agent: KMail/1.13.7 (Linux/3.14-2-amd64; KDE/4.13.1; x86_64; ; )
Cc: linux-input@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>,
        Lee Jones <lee.jones@linaro.org>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>, linux-kernel@vger.kernel.org
References: <20150522225832.GA19831@dtor-ws> <201505231838.54349.marex@denx.de> <3ECB4834-2EEF-471A-B634-EFC95DFF725F@gmail.com>
In-Reply-To: <3ECB4834-2EEF-471A-B634-EFC95DFF725F@gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201505232329.53774.marex@denx.de>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Saturday, May 23, 2015 at 06:41:50 PM, Dmitry Torokhov wrote:
> On May 23, 2015 9:38:54 AM PDT, Marek Vasut <marex@denx.de> wrote:
> >On Saturday, May 23, 2015 at 12:58:32 AM, Dmitry Torokhov wrote:
> >> The STMPE MFD is only used with device tree configured systems (and
> >
> >STMPE
> >
> >> MFD core depends on OF), so force the configuration to come from
> >
> >device
> >
> >> tree only.
> >> 
> >> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> >> ---
> >
> >Hi!
> >
> >[...]
> >
> >> @@ -351,14 +336,13 @@ static int stmpe_input_probe(struct
> >
> >platform_device
> >
> >> *pdev) idev->name = STMPE_TS_NAME;
> >> 
> >>  	idev->phys = STMPE_TS_NAME"/input0";
> >>  	idev->id.bustype = BUS_I2C;
> >> 
> >> -	idev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS);
> >> -	idev->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH);
> >> 
> >>  	idev->open = stmpe_ts_open;
> >>  	idev->close = stmpe_ts_close;
> >>  	
> >>  	input_set_drvdata(idev, ts);
> >> 
> >> +	input_set_capability(idev, EV_KEY, BTN_TOUCH);
> >
> >Isn't this part of the patch dropping the EV_ABS evbit ?
> 
> No, on newer kernels input_set_abs_paramd() takes care of setting we EV_ABS
> in evbit as well.

Oh, I see, thanks for enlightening me!

Reviewed-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut