public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
	Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [char-misc-next 11/11] mei: revamp mei bus code
Date: Sun, 24 May 2015 11:19:49 -0700	[thread overview]
Message-ID: <20150524181949.GA13427@kroah.com> (raw)
In-Reply-To: <1431003248-3164-11-git-send-email-tomas.winkler@intel.com>

On Thu, May 07, 2015 at 03:54:08PM +0300, Tomas Winkler wrote:
> MEI bus was designed around nfc and was hard to extend.
> Instead of hard coded way of adding the devices on the mei bus
> we scan whole me client list and create a device for each
> eligible me client; currently we support only clients with
> single connection and fixed address clients.
> NFC radio name detection is run as a fixup routine
> 
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
>  drivers/misc/mei/Makefile    |   2 +-
>  drivers/misc/mei/bus-fixup.c | 306 ++++++++++++++
>  drivers/misc/mei/bus.c       | 975 ++++++++++++++++++++++++++++---------------
>  drivers/misc/mei/client.c    |   9 +-
>  drivers/misc/mei/init.c      |   5 +-
>  drivers/misc/mei/mei_dev.h   |  24 +-
>  drivers/misc/mei/nfc.c       | 414 ------------------
>  include/linux/mei_cl_bus.h   |  12 +
>  8 files changed, 968 insertions(+), 779 deletions(-)
>  create mode 100644 drivers/misc/mei/bus-fixup.c
>  delete mode 100644 drivers/misc/mei/nfc.c

This is a lot to do in just one patch.  Any chance you can split it up
into reviewable pieces?

thanks,

greg k-h

  reply	other threads:[~2015-05-24 18:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-07 12:53 [char-misc-next 01/11] mei: consume flow control on the first chunk of writing Tomas Winkler
2015-05-07 12:53 ` [char-misc-next 02/11] mei: request autosuspend at the end of write Tomas Winkler
2015-05-07 12:54 ` [char-misc-next 03/11] mei: add also write waiting list to runtime pm blockers Tomas Winkler
2015-05-07 12:54 ` [char-misc-next 04/11] uuid: extract macros for assigning raw arrays Tomas Winkler
2015-05-07 12:54 ` [char-misc-next 05/11] mei: bus: report also uuid in module alias Tomas Winkler
2015-05-07 12:54 ` [char-misc-next 06/11] mei: bus: add name and uuid into device attributes Tomas Winkler
2015-05-07 12:54 ` [char-misc-next 07/11] NFC: mei_phy: move all nfc logic from mei driver to nfc Tomas Winkler
2015-05-07 12:54 ` [char-misc-next 08/11] mei: bus: kill mei_cl_ops Tomas Winkler
2015-05-07 12:54 ` [char-misc-next 09/11] NFC: mei_phy: adjust mei nfc header according the spec Tomas Winkler
2015-05-07 12:54 ` [char-misc-next 10/11] mei: export mei client device struct to external use Tomas Winkler
2015-05-07 12:54 ` [char-misc-next 11/11] mei: revamp mei bus code Tomas Winkler
2015-05-24 18:19   ` Greg KH [this message]
2015-05-24 21:29     ` Winkler, Tomas
2015-05-25  1:46       ` Greg KH
2015-05-25  4:40         ` Winkler, Tomas
2015-05-25 16:20           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150524181949.GA13427@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox