From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751471AbbEXSTw (ORCPT ); Sun, 24 May 2015 14:19:52 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33443 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbbEXSTu (ORCPT ); Sun, 24 May 2015 14:19:50 -0400 Date: Sun, 24 May 2015 11:19:49 -0700 From: Greg KH To: Tomas Winkler Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, Samuel Ortiz Subject: Re: [char-misc-next 11/11] mei: revamp mei bus code Message-ID: <20150524181949.GA13427@kroah.com> References: <1431003248-3164-1-git-send-email-tomas.winkler@intel.com> <1431003248-3164-11-git-send-email-tomas.winkler@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431003248-3164-11-git-send-email-tomas.winkler@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 07, 2015 at 03:54:08PM +0300, Tomas Winkler wrote: > MEI bus was designed around nfc and was hard to extend. > Instead of hard coded way of adding the devices on the mei bus > we scan whole me client list and create a device for each > eligible me client; currently we support only clients with > single connection and fixed address clients. > NFC radio name detection is run as a fixup routine > > Cc: Samuel Ortiz > Signed-off-by: Tomas Winkler > --- > drivers/misc/mei/Makefile | 2 +- > drivers/misc/mei/bus-fixup.c | 306 ++++++++++++++ > drivers/misc/mei/bus.c | 975 ++++++++++++++++++++++++++++--------------- > drivers/misc/mei/client.c | 9 +- > drivers/misc/mei/init.c | 5 +- > drivers/misc/mei/mei_dev.h | 24 +- > drivers/misc/mei/nfc.c | 414 ------------------ > include/linux/mei_cl_bus.h | 12 + > 8 files changed, 968 insertions(+), 779 deletions(-) > create mode 100644 drivers/misc/mei/bus-fixup.c > delete mode 100644 drivers/misc/mei/nfc.c This is a lot to do in just one patch. Any chance you can split it up into reviewable pieces? thanks, greg k-h