From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-serial@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Jiri Slaby <jslaby@suse.cz>,
Peter Hurley <peter@hurleysoftware.com>,
Alan Cox <alan@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org,
Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
Tony Lindgren <tony@atomide.com>,
Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>
Subject: Re: [PATCH] serial: 8250: remove return statements from void function
Date: Sun, 24 May 2015 12:46:09 -0700 [thread overview]
Message-ID: <20150524194609.GB18445@kroah.com> (raw)
In-Reply-To: <1431315022-10526-1-git-send-email-yamada.masahiro@socionext.com>
On Mon, May 11, 2015 at 12:30:22PM +0900, Masahiro Yamada wrote:
> serial8250_set_mctrl() is a void type function. Returning something
> does not look nice.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/tty/serial/8250/8250_core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index 4882027..146f56c 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -2019,8 +2019,9 @@ EXPORT_SYMBOL_GPL(serial8250_do_set_mctrl);
> static void serial8250_set_mctrl(struct uart_port *port, unsigned int mctrl)
> {
> if (port->set_mctrl)
> - return port->set_mctrl(port, mctrl);
> - return serial8250_do_set_mctrl(port, mctrl);
> + port->set_mctrl(port, mctrl);
> + else
> + serial8250_do_set_mctrl(port, mctrl);
> }
You just changed the logic here!
next prev parent reply other threads:[~2015-05-24 19:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 3:30 [PATCH] serial: 8250: remove return statements from void function Masahiro Yamada
2015-05-24 19:46 ` Greg Kroah-Hartman [this message]
2015-05-25 1:53 ` Masahiro Yamada
2015-05-25 16:23 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150524194609.GB18445@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=ricardo.ribalda@gmail.com \
--cc=tony@atomide.com \
--cc=yamada.masahiro@socionext.com \
--cc=yoshihiro.yunomae.ez@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox