From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751746AbbEXTqN (ORCPT <rfc822;w@1wt.eu>);
	Sun, 24 May 2015 15:46:13 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:34169 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751316AbbEXTqK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 24 May 2015 15:46:10 -0400
Date: Sun, 24 May 2015 12:46:09 -0700
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-serial@vger.kernel.org,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Jiri Slaby <jslaby@suse.cz>, Peter Hurley <peter@hurleysoftware.com>,
        Alan Cox <alan@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-kernel@vger.kernel.org,
        Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
        Tony Lindgren <tony@atomide.com>,
        Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>
Subject: Re: [PATCH] serial: 8250: remove return statements from void function
Message-ID: <20150524194609.GB18445@kroah.com>
References: <1431315022-10526-1-git-send-email-yamada.masahiro@socionext.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1431315022-10526-1-git-send-email-yamada.masahiro@socionext.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 11, 2015 at 12:30:22PM +0900, Masahiro Yamada wrote:
> serial8250_set_mctrl() is a void type function.  Returning something
> does not look nice.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  drivers/tty/serial/8250/8250_core.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index 4882027..146f56c 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -2019,8 +2019,9 @@ EXPORT_SYMBOL_GPL(serial8250_do_set_mctrl);
>  static void serial8250_set_mctrl(struct uart_port *port, unsigned int mctrl)
>  {
>  	if (port->set_mctrl)
> -		return port->set_mctrl(port, mctrl);
> -	return serial8250_do_set_mctrl(port, mctrl);
> +		port->set_mctrl(port, mctrl);
> +	else
> +		serial8250_do_set_mctrl(port, mctrl);
>  }

You just changed the logic here!