From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752040AbbEYFtY (ORCPT ); Mon, 25 May 2015 01:49:24 -0400 Received: from mga14.intel.com ([192.55.52.115]:22015 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751039AbbEYFtW (ORCPT ); Mon, 25 May 2015 01:49:22 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,489,1427785200"; d="scan'208";a="497828249" Date: Mon, 25 May 2015 11:20:31 +0530 From: Vinod Koul To: Maninder Singh Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, dan.j.williams@intel.com Subject: Re: [PATCH 1/1] dmaengine: pl330: Initialize pl330 for pl330_prep_dma_memcpy after NULL check of pch Message-ID: <20150525055031.GB3140@localhost> References: <1432491157-2778-1-git-send-email-shanky.cool1992@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 24, 2015 at 06:30:36PM +0530, Maninder Singh wrote: > git send-email missed one line > Add it in description too > > On 24 May 2015 18:11, "Maninder Singh" wrote: > > > > From: Maninder Singh > > > > Currently pch pointer is already dereferenced before NULL check > And thus we are getting below warning: > Warn: variable dereferenced before check 'pch' no you resend the patch with this description and this is something we need here -- ~Vinod > > > So initialize struct pl330_dmac *pl330 after NULL check > > of dma_pl330_chan *pch. > > > > Signed-off-by: Maninder Singh > > Reviewed-by: Vaneet Narang > > --- > > drivers/dma/pl330.c | 4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c > > index a7d9d30..7e27144 100644 > > --- a/drivers/dma/pl330.c > > +++ b/drivers/dma/pl330.c > > @@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, > dma_addr_t dst, > > { > > struct dma_pl330_desc *desc; > > struct dma_pl330_chan *pch = to_pchan(chan); > > - struct pl330_dmac *pl330 = pch->dmac; > > + struct pl330_dmac *pl330; > > int burst; > > > > if (unlikely(!pch || !len)) > > return NULL; > > > > + pl330 = pch->dmac; > > + > > desc = __pl330_prep_dma_memcpy(pch, dst, src, len); > > if (!desc) > > return NULL; > > -- > > 1.7.1 --