From: Dan Carpenter <dan.carpenter@oracle.com>
To: James Simmons <jsimmons@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
HPDD-discuss@ml01.01.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
lustre-devel@lists.lustre.org
Subject: Re: [PATCH 5/6] staging:lustre: style cleanups for lib-socket.c
Date: Mon, 25 May 2015 12:37:38 +0300 [thread overview]
Message-ID: <20150525093737.GS4150@mwanda> (raw)
In-Reply-To: <1432319552-10479-6-git-send-email-jsimmons@infradead.org>
On Fri, May 22, 2015 at 02:32:31PM -0400, James Simmons wrote:
> @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp)
> if (nalloc * sizeof(*ifr) > PAGE_CACHE_SIZE) {
> toobig = 1;
> nalloc = PAGE_CACHE_SIZE/sizeof(*ifr);
> - CWARN("Too many interfaces: only enumerating first %d\n",
> - nalloc);
> + CWARN("Too many interfaces: only enumerating "
> + "first %d\n", nalloc);
> }
Don't split string literals, it makes them hard to grep for.
regards,
dan carpenter
next prev parent reply other threads:[~2015-05-25 9:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <uja.ornl@gmail.com>
2015-05-21 22:46 ` [PATCH 0/3] First set of Intel branch merger for libcfs/lnet James Simmons
2015-05-22 18:32 ` [PATCH 1/6] staging:lustre:remove useless libcfs_sock_release James Simmons
2015-05-22 18:32 ` [PATCH 2/6] staging:lustre:remove useless libcfs_sock_abort_accept James Simmons
2015-05-22 18:32 ` [PATCH 3/6] staging:lustre: rename tcpip handling functions to lnet_* prefix James Simmons
2015-05-22 18:32 ` [PATCH 4/6] staging:lustre: use available kernel wrappers in lib-socket.c James Simmons
2015-05-22 18:32 ` [PATCH 5/6] staging:lustre: style cleanups for lib-socket.c James Simmons
2015-05-25 9:37 ` Dan Carpenter [this message]
2015-05-27 15:01 ` [lustre-devel] " Simmons, James A.
2015-05-27 15:24 ` Dan Carpenter
2015-05-27 21:04 ` Simmons, James A.
2015-05-22 18:32 ` [PATCH 6/6] staging:lustre: Update license and copyright " James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150525093737.GS4150@mwanda \
--to=dan.carpenter@oracle.com \
--cc=HPDD-discuss@ml01.01.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).