From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752176AbbEYJia (ORCPT ); Mon, 25 May 2015 05:38:30 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:33239 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750859AbbEYJi1 (ORCPT ); Mon, 25 May 2015 05:38:27 -0400 Date: Mon, 25 May 2015 12:37:38 +0300 From: Dan Carpenter To: James Simmons Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Oleg Drokin , Andreas Dilger , HPDD-discuss@ml01.01.org, Linux Kernel Mailing List , lustre-devel@lists.lustre.org Subject: Re: [PATCH 5/6] staging:lustre: style cleanups for lib-socket.c Message-ID: <20150525093737.GS4150@mwanda> References: <1432319552-10479-6-git-send-email-jsimmons@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432319552-10479-6-git-send-email-jsimmons@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 22, 2015 at 02:32:31PM -0400, James Simmons wrote: > @@ -167,13 +164,14 @@ lnet_ipif_enumerate (char ***namesp) > if (nalloc * sizeof(*ifr) > PAGE_CACHE_SIZE) { > toobig = 1; > nalloc = PAGE_CACHE_SIZE/sizeof(*ifr); > - CWARN("Too many interfaces: only enumerating first %d\n", > - nalloc); > + CWARN("Too many interfaces: only enumerating " > + "first %d\n", nalloc); > } Don't split string literals, it makes them hard to grep for. regards, dan carpenter