public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Darren Hart <dvhart@infradead.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Valdis Kletnieks <Valdis.Kletnieks@vt.edu>,
	lkml <linux-kernel@vger.kernel.org>,
	platform-driver-x86@vger.kernel.org,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: dell_rbtn - kernel panic at boot...
Date: Mon, 25 May 2015 16:40:14 +0200	[thread overview]
Message-ID: <20150525144014.GC23037@pali> (raw)
In-Reply-To: <20150525044432.GA38428@fury.dvhart.com>

On Sunday 24 May 2015 21:44:32 Darren Hart wrote:
> On Sat, May 23, 2015 at 03:05:36AM +0200, Pali Rohár wrote:
> > On Saturday 23 May 2015 00:53:16 Dmitry Torokhov wrote:
> > > On Thu, May 21, 2015 at 7:06 PM, Valdis Kletnieks
> > > 
> > > <Valdis.Kletnieks@vt.edu> wrote:
> > > > So after I made both config variables =y, the resulting kernel
> > > > built, but died a glorious death at boot.
> > > 
> > > I guess if both are built-in then, according to link order,
> > > dell-laptop starts first, before dell-rbtn, and dies in
> > > dell_rbtn_notifier_register() in call to
> > > driver_for_each_device(&rbtn_driver.drv, ...) because rbtn_driver has
> > > not been registered yet and thus half-initlalized.
> > > 
> > > Thanks.
> > 
> > pr_debug() messages could be useful... but no idea if we can get them.
> > 
> > Is there any way to fix that dependency race condition? Could 
> > driver_attach() function call help?
> 
> I believe you can avoid this by moving dell-rbtn earlier in the Makefile than
> dell-laptop - but this is fragile and a hack to resolve a dependency problem.
> 

And what about that late_initcall() instead module_init() in dell-laptop?
Will it fix this problem?

-- 
Pali Rohár
pali.rohar@gmail.com

  parent reply	other threads:[~2015-05-25 14:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22  2:06 dell_rbtn - kernel panic at boot Valdis Kletnieks
2015-05-22 22:53 ` Dmitry Torokhov
2015-05-23  1:05   ` Pali Rohár
2015-05-23 20:08     ` Pali Rohár
2015-05-25  4:44     ` Darren Hart
2015-05-25  5:01       ` Matthew Garrett
2015-05-25  6:03         ` Pali Rohár
2015-05-27  4:16           ` Darren Hart
2015-05-27  7:28             ` Pali Rohár
2015-05-29  3:15               ` Darren Hart
2015-05-25 14:40       ` Pali Rohár [this message]
2015-05-27  4:09         ` Darren Hart
2015-05-27  4:24           ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150525144014.GC23037@pali \
    --to=pali.rohar@gmail.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox