From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751263AbbEYQVA (ORCPT ); Mon, 25 May 2015 12:21:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45574 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750853AbbEYQU7 (ORCPT ); Mon, 25 May 2015 12:20:59 -0400 Date: Mon, 25 May 2015 09:20:58 -0700 From: Greg KH To: "Winkler, Tomas" Cc: "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , Samuel Ortiz Subject: Re: [char-misc-next 11/11] mei: revamp mei bus code Message-ID: <20150525162058.GE9772@kroah.com> References: <1431003248-3164-1-git-send-email-tomas.winkler@intel.com> <1431003248-3164-11-git-send-email-tomas.winkler@intel.com> <20150524181949.GA13427@kroah.com> <5B8DA87D05A7694D9FA63FD143655C1B3C4A0BB3@hasmsx109.ger.corp.intel.com> <20150525014629.GA5838@kroah.com> <5B8DA87D05A7694D9FA63FD143655C1B3C4A0C0A@hasmsx109.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B3C4A0C0A@hasmsx109.ger.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 25, 2015 at 04:40:50AM +0000, Winkler, Tomas wrote: > > > > > This is a lot to do in just one patch. Any chance you can split it up > > > > into reviewable pieces? > > > > > > I thought it would be harder to swallow but I'm not sure how to really > > > split this into working pieces w/o do some artificial steps which > > > I will have to validate again to keep the code bisectable. > > > > That's fine, that's your job to do :) > > I'd would prefer to do something that wasn't' already done. Huh? Your job is to split changes up into tiny logical pieces that are easy to review. That isn't "done" here. > > > What could be naturally factored out is already in separate patches in this > > series. > > > The patch is maybe bigger because of code moves between files but what has > > really changes is just bus.c > > > > Then do the movement of functions around in one patch, and then the > > logical changes in others. Come on, you know how this whole thing > > works, don't be lazy here... > > > Yep, I know how it works, but here it just didn't fit as the logical changes moved also the code. > Okay, I will split the code but allow me one comment, I think that you were lazy too go into details and you didn't send us to hell when we first submitted that bus code. So because I wasn't hard enough on your initial reviews of this code, you are now blaming me for this needed rework? I seem to recall that I gave a lot of feedback on those original patches, but if you want me to be harder and take a much closer look at all of your patches, I'll be glad to do so. Be aware, that this is going to slow down the acceptance rates of your patches, and I am going to now be _very_ pedantic and grumpy. Remember, you asked for it, this is going to be fun, for me, not you... greg k-h