From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751358AbbEYQXL (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 May 2015 12:23:11 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:45589 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751293AbbEYQXH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 May 2015 12:23:07 -0400
Date: Mon, 25 May 2015 09:23:06 -0700
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-serial@vger.kernel.org,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Jiri Slaby <jslaby@suse.cz>, Peter Hurley <peter@hurleysoftware.com>,
        Alan Cox <alan@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
        Tony Lindgren <tony@atomide.com>,
        Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>
Subject: Re: [PATCH] serial: 8250: remove return statements from void function
Message-ID: <20150525162306.GG9772@kroah.com>
References: <1431315022-10526-1-git-send-email-yamada.masahiro@socionext.com>
 <20150524194609.GB18445@kroah.com>
 <CAK7LNARZfr4OS0oS_sGr1zG=G+=pwzCPZNGSC+_wi3+pRza=_A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK7LNARZfr4OS0oS_sGr1zG=G+=pwzCPZNGSC+_wi3+pRza=_A@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 25, 2015 at 10:53:03AM +0900, Masahiro Yamada wrote:
> 2015-05-25 4:46 GMT+09:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> > On Mon, May 11, 2015 at 12:30:22PM +0900, Masahiro Yamada wrote:
> >> serial8250_set_mctrl() is a void type function.  Returning something
> >> does not look nice.
> >>
> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >> ---
> >>
> >>  drivers/tty/serial/8250/8250_core.c | 5 +++--
> >>  1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> >> index 4882027..146f56c 100644
> >> --- a/drivers/tty/serial/8250/8250_core.c
> >> +++ b/drivers/tty/serial/8250/8250_core.c
> >> @@ -2019,8 +2019,9 @@ EXPORT_SYMBOL_GPL(serial8250_do_set_mctrl);
> >>  static void serial8250_set_mctrl(struct uart_port *port, unsigned int mctrl)
> >>  {
> >>       if (port->set_mctrl)
> >> -             return port->set_mctrl(port, mctrl);
> >> -     return serial8250_do_set_mctrl(port, mctrl);
> >> +             port->set_mctrl(port, mctrl);
> >> +     else
> >> +             serial8250_do_set_mctrl(port, mctrl);
> >>  }
> >
> > You just changed the logic here!
> 
> 
> Could you tell me why?
> 
> The logic still looks the same to me.

{sigh} you are right.  Sorry about that, I'll go dig up the original
patch and queue it up, this was my fault in reading the code
incorrectly.

greg k-h