public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Nikhil Badola <nikhil.badola@freescale.com>
Cc: linux-kernel@vger.kernel.org,
	Ramneek Mehresh <ramneek.mehresh@freescale.com>
Subject: Re: [PATCH] drivers:usb:fsl: Introduce FSL_USB2_PHY_UTMI_DUAL macro
Date: Mon, 25 May 2015 09:27:40 -0700	[thread overview]
Message-ID: <20150525162740.GH9772@kroah.com> (raw)
In-Reply-To: <1432546054-21496-1-git-send-email-nikhil.badola@freescale.com>

On Mon, May 25, 2015 at 02:57:34PM +0530, Nikhil Badola wrote:
> Introduce FSL_USB2_PHY_UTMI_DUAL macro for setting phy mode
> in SOCs such has T4240, T1040, T2080 which have utmi dual-phy
> 
> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com>
> ---
>  drivers/usb/host/ehci-fsl.c      | 1 +
>  drivers/usb/host/fsl-mph-dr-of.c | 2 ++
>  include/linux/fsl_devices.h      | 1 +
>  3 files changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index ab4eee3..1f0e4e0 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -226,6 +226,7 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,
>  		portsc |= PORT_PTS_PTW;
>  		/* fall through */
>  	case FSL_USB2_PHY_UTMI:
> +	case FSL_USB2_PHY_UTMI_DUAL:
>  		if (pdata->have_sysif_regs && pdata->controller_ver) {
>  			/* controller version 1.6 or above */
>  			setbits32(non_ehci + FSL_SOC_USB_CTRL, UTMI_PHY_EN);
> diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
> index 7e325e9..ed39081 100644
> --- a/drivers/usb/host/fsl-mph-dr-of.c
> +++ b/drivers/usb/host/fsl-mph-dr-of.c
> @@ -69,6 +69,8 @@ static enum fsl_usb2_phy_modes determine_usb_phy(const char *phy_type)
>  		return FSL_USB2_PHY_UTMI;
>  	if (!strcasecmp(phy_type, "utmi_wide"))
>  		return FSL_USB2_PHY_UTMI_WIDE;
> +	if (!strcasecmp(phy_type, "utmi_dual"))
> +		return FSL_USB2_PHY_UTMI_DUAL;
>  	if (!strcasecmp(phy_type, "serial"))
>  		return FSL_USB2_PHY_SERIAL;
>  
> diff --git a/include/linux/fsl_devices.h b/include/linux/fsl_devices.h
> index a82296a..dd73fad 100644
> --- a/include/linux/fsl_devices.h
> +++ b/include/linux/fsl_devices.h
> @@ -64,6 +64,7 @@ enum fsl_usb2_phy_modes {
>  	FSL_USB2_PHY_UTMI,
>  	FSL_USB2_PHY_UTMI_WIDE,
>  	FSL_USB2_PHY_SERIAL,
> +	FSL_USB2_PHY_UTMI_DUAL,
>  };
>  

Don't you need to order these patches properly so that they are applied
in the correct way?  Please send these as a numbered series.

Also, please cc: the linux-usb mailing list, use
scripts/get_maintainer.pl for getting the correct people and mailing
lists.

thanks,

greg k-h

      reply	other threads:[~2015-05-25 16:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-25  9:27 [PATCH] drivers:usb:fsl: Introduce FSL_USB2_PHY_UTMI_DUAL macro Nikhil Badola
2015-05-25 16:27 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150525162740.GH9772@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikhil.badola@freescale.com \
    --cc=ramneek.mehresh@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox