From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751141AbbEYQbt (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 May 2015 12:31:49 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:44592 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750771AbbEYQbr (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 May 2015 12:31:47 -0400
Date: Mon, 25 May 2015 19:31:18 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: tolga ceylan <tolga.ceylan@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Cristina Opriceana <cristina.opriceana@gmail.com>,
        Haneen Mohammed <hamohammed.sa@gmail.com>,
        Greg Donald <gdonald@gmail.com>,
        Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
        Benoit Taine <benoit.taine@lip6.fr>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers: staging: rtl8192u: ieee80211:
 ieee80211_softmac.c: auth parse error code byte order fix
Message-ID: <20150525163118.GD11588@mwanda>
References: <1431489344-1206-1-git-send-email-tolga.ceylan@gmail.com>
 <55613D28.90609@gmail.com>
 <5563406A.3010202@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5563406A.3010202@windriver.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: userv0022.oracle.com [156.151.31.74]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Good advice.  This was actually found by Sparse and the changelog should
say:

Sparse complains about this:

ieee80211_softmac.c:1561:16: warning: cast from restricted __le16
ieee80211_softmac.c:1561:16: warning: incorrect type in return expression (different base types)
ieee80211_softmac.c:1561:16:    expected unsigned short
ieee80211_softmac.c:1561:16:    got restricted __le16 [usertype] <noident>

The caller basically only cares about zero and non-zero so it doesn't
affect runtime (except for making an debug message more accurate).

regards,
dan carpenter