From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751099AbbEYQff (ORCPT ); Mon, 25 May 2015 12:35:35 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:18952 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbbEYQfe (ORCPT ); Mon, 25 May 2015 12:35:34 -0400 Date: Mon, 25 May 2015 19:35:12 +0300 From: Dan Carpenter To: Gaston Gonzalez Cc: gregkh@linuxfoundation.org, cristina.opriceana@gmail.com, hamohammed.sa@gmail.com, gdonald@gmail.com, mahfouz.saif.elyazal@gmail.com, paul.gortmaker@windriver.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse endianness warning Message-ID: <20150525163512.GE11588@mwanda> References: <1432566042-16688-1-git-send-email-gascoar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432566042-16688-1-git-send-email-gascoar@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 25, 2015 at 12:00:42PM -0300, Gaston Gonzalez wrote: > Silence the following sparse warning: > > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: warning: incorrect type in assignment (different base types) > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: expected restricted __le16 [usertype] frame_ctl > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: got int > > Signed-off-by: Gaston Gonzalez > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > index d2e8b12..7dd8442 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > @@ -660,2 +660,2 @@ inline struct sk_buff *ieee80211_authentication_req(struct ieee80211_network *be > auth = (struct ieee80211_authentication *) > skb_put(skb, sizeof(struct ieee80211_authentication)); > > - auth->header.frame_ctl = IEEE80211_STYPE_AUTH; > + auth->header.frame_ctl = cpu_to_le16(IEEE80211_STYPE_AUTH); > if (challengelen) auth->header.frame_ctl |= IEEE80211_FCTL_WEP; ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This is also wrong then. regards, dan carpenter