From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751275AbbEYQvv (ORCPT ); Mon, 25 May 2015 12:51:51 -0400 Received: from mga03.intel.com ([134.134.136.65]:31026 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751065AbbEYQvt (ORCPT ); Mon, 25 May 2015 12:51:49 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,493,1427785200"; d="scan'208";a="734992774" Date: Mon, 25 May 2015 22:22:57 +0530 From: Vinod Koul To: Robert Jarzmik Cc: Maxime Ripard , Jonathan Corbet , Daniel Mack , Haojian Zhuang , dmaengine@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 6/6] Documentation: dmaengine: document DMA_CTRL_ACK Message-ID: <20150525165257.GI3140@localhost> References: <1431626006-1708-1-git-send-email-robert.jarzmik@free.fr> <1431626006-1708-6-git-send-email-robert.jarzmik@free.fr> <20150514183853.GN4004@lukather> <87twvekij8.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87twvekij8.fsf@belgarion.home> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 14, 2015 at 10:31:39PM +0200, Robert Jarzmik wrote: > Maxime Ripard writes: > > > Hi Robert, > > > >> * DMA_CTRL_ACK > >> - - Undocumented feature > >> - - No one really has an idea of what it's about, besides being > >> - related to reusing the DMA transaction descriptors or having > >> - additional transactions added to it in the async-tx API > >> - - Useless in the case of the slave API > >> + - if set, the TX transfer can be reused after being completed. > > > > Your sentences should start with an upper-case letter. > Ack. > > >> + - there is a guarantee the TX won't be freed until it is acked > >> + by async_tx_ack() > > > > We never talked about what a "TX transfer" is in the > > documentation. That should be documented. > I'll remove the "TX", the transfer is widely used in this documentation. > > > > >> + - as a consequence, if a device driver wants to skip the dma_map_sg() and > >> + dma_unmap_sg() because the DMA'd data wasn't used, it can resubmit the > >> + transfer right after its completion. > > > > From a provider PoV, the data should always be mapped and / or > > allocated in coherent way, so I'm not sure how does that's relevant in > > the provider doc. > It's relevant because it says the mapping/unmapping is not necessary _between_ 2 > submission of a transfer. This implies it is mapped, as it is a requirement for > the very first submission. > > > Also, we should still mention that it's !slave API only. > Certainly not, it's fully slave API, that's the purpose of this patch. Its is not dependent on slave, it cna be used by slave as well as other users -- ~Vinod