* [PATCH 1/1] dmaengine: pl330: Initialize pl330 for pl330_prep_dma_memcpy after NULL check of pch
@ 2015-05-24 18:12 Maninder Singh
[not found] ` <CAPmXEtt9yR_eWYhZJzz4k=Ay9kR_emxEQCNB2GvLZLphGYv5Eg@mail.gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: Maninder Singh @ 2015-05-24 18:12 UTC (permalink / raw)
To: vinod.koul, dan.j.williams, dmaengine, linux-kernel; +Cc: Maninder Singh
From: Maninder Singh <maninder1.s@samsung.com>
So initialize struct pl330_dmac *pl330 after NULL check
of dma_pl330_chan *pch.
Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-by: Vaneet Narang <v.narang@samsung.com>
---
drivers/dma/pl330.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index a7d9d30..7e27144 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
{
struct dma_pl330_desc *desc;
struct dma_pl330_chan *pch = to_pchan(chan);
- struct pl330_dmac *pl330 = pch->dmac;
+ struct pl330_dmac *pl330;
int burst;
if (unlikely(!pch || !len))
return NULL;
+ pl330 = pch->dmac;
+
desc = __pl330_prep_dma_memcpy(pch, dst, src, len);
if (!desc)
return NULL;
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] dmaengine: pl330: Initialize pl330 for pl330_prep_dma_memcpy after NULL check of pch
[not found] ` <CAPmXEtt9yR_eWYhZJzz4k=Ay9kR_emxEQCNB2GvLZLphGYv5Eg@mail.gmail.com>
@ 2015-05-25 5:50 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2015-05-25 5:50 UTC (permalink / raw)
To: Maninder Singh; +Cc: linux-kernel, dmaengine, dan.j.williams
On Sun, May 24, 2015 at 06:30:36PM +0530, Maninder Singh wrote:
> git send-email missed one line
> Add it in description too
>
> On 24 May 2015 18:11, "Maninder Singh" <shanky.cool1992@gmail.com> wrote:
> >
> > From: Maninder Singh <maninder1.s@samsung.com>
> >
>
> Currently pch pointer is already dereferenced before NULL check
> And thus we are getting below warning:
> Warn: variable dereferenced before check 'pch'
no you resend the patch with this description and this is something we need
here
--
~Vinod
>
> > So initialize struct pl330_dmac *pl330 after NULL check
> > of dma_pl330_chan *pch.
> >
> > Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> > Reviewed-by: Vaneet Narang <v.narang@samsung.com>
> > ---
> > drivers/dma/pl330.c | 4 +++-
> > 1 files changed, 3 insertions(+), 1 deletions(-)
> > diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> > index a7d9d30..7e27144 100644
> > --- a/drivers/dma/pl330.c
> > +++ b/drivers/dma/pl330.c
> > @@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan,
> dma_addr_t dst,
> > {
> > struct dma_pl330_desc *desc;
> > struct dma_pl330_chan *pch = to_pchan(chan);
> > - struct pl330_dmac *pl330 = pch->dmac;
> > + struct pl330_dmac *pl330;
> > int burst;
> >
> > if (unlikely(!pch || !len))
> > return NULL;
> >
> > + pl330 = pch->dmac;
> > +
> > desc = __pl330_prep_dma_memcpy(pch, dst, src, len);
> > if (!desc)
> > return NULL;
> > --
> > 1.7.1
--
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] dmaengine: pl330: Initialize pl330 for pl330_prep_dma_memcpy after NULL check of pch
2015-05-25 19:10 [PATCH 1/1] dmaengine: pl330: Initialize pl330 for pl330_prep_dma_memcpy after NULL check of pch Maninder Singh
@ 2015-05-25 17:09 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2015-05-25 17:09 UTC (permalink / raw)
To: Maninder Singh; +Cc: dan.j.williams, dmaengine, linux-kernel, Maninder Singh
On Tue, May 26, 2015 at 12:40:05AM +0530, Maninder Singh wrote:
> From: Maninder Singh <maninder1.s@samsung.com>
>
> Currently pch pointer is already dereferenced before NULL check
> and thus we are getting below warning:
> warn: variable dereferenced before check 'pch'
>
> So initialize struct pl330_dmac *pl330 after NULL check
> of dma_pl330_chan *pch.
>
Applied, thanks
--
~Vinod
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Reviewed-by: Vaneet Narang <v.narang@samsung.com>
> ---
> drivers/dma/pl330.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index a7d9d30..7e27144 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
> {
> struct dma_pl330_desc *desc;
> struct dma_pl330_chan *pch = to_pchan(chan);
> - struct pl330_dmac *pl330 = pch->dmac;
> + struct pl330_dmac *pl330;
> int burst;
>
> if (unlikely(!pch || !len))
> return NULL;
>
> + pl330 = pch->dmac;
> +
> desc = __pl330_prep_dma_memcpy(pch, dst, src, len);
> if (!desc)
> return NULL;
> --
> 1.7.1
--
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] dmaengine: pl330: Initialize pl330 for pl330_prep_dma_memcpy after NULL check of pch
@ 2015-05-25 19:10 Maninder Singh
2015-05-25 17:09 ` Vinod Koul
0 siblings, 1 reply; 4+ messages in thread
From: Maninder Singh @ 2015-05-25 19:10 UTC (permalink / raw)
To: vinod.koul, dan.j.williams, dmaengine, linux-kernel; +Cc: Maninder Singh
From: Maninder Singh <maninder1.s@samsung.com>
Currently pch pointer is already dereferenced before NULL check
and thus we are getting below warning:
warn: variable dereferenced before check 'pch'
So initialize struct pl330_dmac *pl330 after NULL check
of dma_pl330_chan *pch.
Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-by: Vaneet Narang <v.narang@samsung.com>
---
drivers/dma/pl330.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index a7d9d30..7e27144 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
{
struct dma_pl330_desc *desc;
struct dma_pl330_chan *pch = to_pchan(chan);
- struct pl330_dmac *pl330 = pch->dmac;
+ struct pl330_dmac *pl330;
int burst;
if (unlikely(!pch || !len))
return NULL;
+ pl330 = pch->dmac;
+
desc = __pl330_prep_dma_memcpy(pch, dst, src, len);
if (!desc)
return NULL;
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-25 17:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-25 19:10 [PATCH 1/1] dmaengine: pl330: Initialize pl330 for pl330_prep_dma_memcpy after NULL check of pch Maninder Singh
2015-05-25 17:09 ` Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2015-05-24 18:12 Maninder Singh
[not found] ` <CAPmXEtt9yR_eWYhZJzz4k=Ay9kR_emxEQCNB2GvLZLphGYv5Eg@mail.gmail.com>
2015-05-25 5:50 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox