public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>,
	Aaron Fabbri <aaronx.j.fabbri@intel.com>,
	linux-kernel@vger.kernel.org,
	cti.systems-productivity-manager.ts@hitachi.com,
	Divya Vyas <edivya.vyas@gmail.com>,
	Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
	yoshihiro.yunomae@aktsk.jp
Subject: [PATCH trace-cmd V6 1/7] trace-cmd: Support -N option for trace-cmd extract
Date: Tue, 26 May 2015 15:55:24 +0900	[thread overview]
Message-ID: <20150526065524.16023.68225.stgit@localhost.localdomain> (raw)
In-Reply-To: <20150526065522.16023.30813.stgit@localhost.localdomain>

From: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>

There is no reason to prohibit supporting -N command in extract
mode, since both record and extract read trace logs from ftrace
and save it.

Signed-off-by: Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>
Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
---
 trace-record.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/trace-record.c b/trace-record.c
index 9874a12..c387aff 100644
--- a/trace-record.c
+++ b/trace-record.c
@@ -520,6 +520,7 @@ static void stop_threads(enum trace_type type)
 
 static int create_recorder(struct buffer_instance *instance, int cpu,
 			   enum trace_type type, int *brass);
+static void setup_network(void);
 
 static void flush_threads(void)
 {
@@ -529,6 +530,9 @@ static void flush_threads(void)
 	if (!cpu_count)
 		return;
 
+	if (host)
+		setup_network();
+
 	for (i = 0; i < cpu_count; i++) {
 		/* Extract doesn't support sub buffers yet */
 		ret = create_recorder(&top_instance, i, TRACE_TYPE_EXTRACT, NULL);
@@ -4047,8 +4051,8 @@ void trace_record (int argc, char **argv)
 			rt_prio = atoi(optarg);
 			break;
 		case 'N':
-			if (!record)
-				die("-N only available with record");
+			if (!record && !extract)
+				die("-N only available with record or extract");
 			if (output)
 				die("-N incompatible with -o");
 			host = optarg;


  reply	other threads:[~2015-05-26  6:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-26  6:55 [PATCH trace-cmd V6 0/7] trce-cmd: add virtual machine tracing Masami Hiramatsu
2015-05-26  6:55 ` Masami Hiramatsu [this message]
2015-05-26  6:55 ` [PATCH trace-cmd V6 2/7] trace-cmd/listen: Introduce trace-msg protocol (protocol v2) Masami Hiramatsu
2015-05-26  6:55 ` [PATCH trace-cmd V6 3/7] trace-cmd/msg: Use poll(2) to wait for a message Masami Hiramatsu
2015-05-26  6:55 ` [PATCH trace-cmd V6 4/7] trace-cmd/virt-server: Add virt-server mode for a virtualization environment Masami Hiramatsu
2015-05-26  6:55 ` [PATCH trace-cmd V6 5/7] trace-cmd/record: Add --virt option for record mode Masami Hiramatsu
2015-05-26  6:55 ` [PATCH trace-cmd V6 6/7] trace-cmd/virt-server: Add --dom option which makes a domain directory to virt-server Masami Hiramatsu
2015-05-26  6:55 ` [PATCH trace-cmd V6 7/7] trace-cmd: Use pid instead of libvirt virt domain name Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150526065524.16023.68225.stgit@localhost.localdomain \
    --to=masami.hiramatsu.pt@hitachi.com \
    --cc=aaronx.j.fabbri@intel.com \
    --cc=cti.systems-productivity-manager.ts@hitachi.com \
    --cc=edivya.vyas@gmail.com \
    --cc=hidehiro.kawai.ez@hitachi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=yoshihiro.yunomae.ez@hitachi.com \
    --cc=yoshihiro.yunomae@aktsk.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox