From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
Jani Nikula <jani.nikula@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] Revert "drm/i915: Force clean compilation with -Werror"
Date: Tue, 26 May 2015 10:20:26 +0200 [thread overview]
Message-ID: <20150526082026.GG12971@phenom.ffwll.local> (raw)
In-Reply-To: <20150526075713.GB20703@nuc-i3427.alporthouse.com>
On Tue, May 26, 2015 at 08:57:13AM +0100, Chris Wilson wrote:
> On Tue, May 26, 2015 at 07:47:22AM +0200, Daniel Vetter wrote:
> > This reverts commit 118182e9d7d5afa0c7c10f568afb46ab78b462e9.
> >
> > It's causing too much trouble when compile-testing for non-i915 folks.
>
> What's the argument against using COMPILE_TEST as a proxy for detecting
> all(yes|mod)config as in Damien's patch?
I also thought about random users bisecting who'll then also might trip
over this. Figure that overall the benefit isn't good enough given the
trouble this seems to have caused immediately. 0-day is pretty fast at
screaming around about new compiler warnings anyway, for the cases where I
miss them.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2015-05-26 8:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 5:47 [PATCH] Revert "drm/i915: Force clean compilation with -Werror" Daniel Vetter
2015-05-26 7:57 ` Chris Wilson
2015-05-26 8:20 ` Daniel Vetter [this message]
2015-05-26 8:39 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526082026.GG12971@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=akpm@linux-foundation.org \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox