From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gaston Gonzalez <gascoar@gmail.com>
Cc: devel@driverdev.osuosl.org, hamohammed.sa@gmail.com,
paul.gortmaker@windriver.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, gdonald@gmail.com,
cristina.opriceana@gmail.com
Subject: Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse endianness warning
Date: Tue, 26 May 2015 11:25:44 +0300 [thread overview]
Message-ID: <20150526082544.GF11588@mwanda> (raw)
In-Reply-To: <5563A74F.4090401@gmail.com>
Btw, the subject should say "fix endian bug". "silence" means that
their is a warning and possible some messy code but no runtime bug.
On Mon, May 25, 2015 at 07:50:55PM -0300, Gaston Gonzalez wrote:
> On 25/05/15 13:35, Dan Carpenter wrote:
> > This is also wrong then.
> >
> > regards,
> > dan carpenter
> Hi Dan,
>
> Yes, you are right. It is the next sparse warning in line for that file.
> Including the fix for that, the patch would be as showed below.
>
> There are similar endianness warnings for other variables in that file,
> like the FIXME in last line of the patch. But keeping in mind the rule
> 'one thing per patch' I guess this should be fixed in other patche/s, right?
The one thing per patch rule is a bit fuzzy. It depends on how you sell
it a bit. I wouldn't mind if you fixed the whole function at once. Or
even all then endian bugs in a file if the patch wasn't too complicated.
But this is also acceptable to fix one struct member so send your
proposed patch.
regards,
dan carpenter
prev parent reply other threads:[~2015-05-26 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 15:00 [PATCH] staging: rtl8192u: ieee80211: Silence sparse endianness warning Gaston Gonzalez
2015-05-25 16:35 ` Dan Carpenter
2015-05-25 22:50 ` Gaston Gonzalez
2015-05-26 5:12 ` Sudip Mukherjee
2015-05-26 8:25 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526082544.GF11588@mwanda \
--to=dan.carpenter@oracle.com \
--cc=cristina.opriceana@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gascoar@gmail.com \
--cc=gdonald@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hamohammed.sa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox