From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932625AbbEZOXM (ORCPT ); Tue, 26 May 2015 10:23:12 -0400 Received: from userp1050.oracle.com ([156.151.31.82]:47368 "EHLO userp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752340AbbEZOXJ (ORCPT ); Tue, 26 May 2015 10:23:09 -0400 X-Greylist: delayed 342 seconds by postgrey-1.27 at vger.kernel.org; Tue, 26 May 2015 10:23:08 EDT Date: Tue, 26 May 2015 11:25:44 +0300 From: Dan Carpenter To: Gaston Gonzalez Cc: devel@driverdev.osuosl.org, hamohammed.sa@gmail.com, paul.gortmaker@windriver.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, gdonald@gmail.com, cristina.opriceana@gmail.com Subject: Re: [PATCH] staging: rtl8192u: ieee80211: Silence sparse endianness warning Message-ID: <20150526082544.GF11588@mwanda> References: <1432566042-16688-1-git-send-email-gascoar@gmail.com> <20150525163512.GE11588@mwanda> <5563A74F.4090401@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5563A74F.4090401@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userp1040.oracle.com [156.151.31.81] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Btw, the subject should say "fix endian bug". "silence" means that their is a warning and possible some messy code but no runtime bug. On Mon, May 25, 2015 at 07:50:55PM -0300, Gaston Gonzalez wrote: > On 25/05/15 13:35, Dan Carpenter wrote: > > This is also wrong then. > > > > regards, > > dan carpenter > Hi Dan, > > Yes, you are right. It is the next sparse warning in line for that file. > Including the fix for that, the patch would be as showed below. > > There are similar endianness warnings for other variables in that file, > like the FIXME in last line of the patch. But keeping in mind the rule > 'one thing per patch' I guess this should be fixed in other patche/s, right? The one thing per patch rule is a bit fuzzy. It depends on how you sell it a bit. I wouldn't mind if you fixed the whole function at once. Or even all then endian bugs in a file if the patch wasn't too complicated. But this is also acceptable to fix one struct member so send your proposed patch. regards, dan carpenter