From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
patches@opensource.wolfsonmicro.com,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Lars-Peter Clausen <lars@metafoo.de>,
Daniel Mack <daniel@zonque.org>, Wolfram Sang <wsa@the-dreams.de>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
Matt Reimer <mreimer@sdgsystems.com>
Subject: Re: [PATCH] ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask
Date: Tue, 26 May 2015 10:44:22 +0100 [thread overview]
Message-ID: <20150526094422.GI21577@sirena.org.uk> (raw)
In-Reply-To: <s5h382j29ey.wl-tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 445 bytes --]
On Tue, May 26, 2015 at 07:29:57AM +0200, Takashi Iwai wrote:
> Maciej S. Szmigiero wrote:
> > Found out by sparse on 0-day kernel tester.
> Wow, that made me wonder how these drivers could actually work.
AFAICT the bits were being set by being ored in from the sequential
values.
> BTW, how did you detect it? Any static analyzer like sparse or
> smatch? sparse didn't detect it at the last time I tried, IIRC...
Commit log says sparse.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-05-26 9:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-23 16:32 [PATCH] ASoC: codecs: use SNDRV_PCM_FMTBIT_* for format bitmask Maciej S. Szmigiero
2015-05-25 8:49 ` Charles Keepax
2015-05-25 12:00 ` Mark Brown
2015-05-26 5:29 ` Takashi Iwai
2015-05-26 9:44 ` Mark Brown [this message]
2015-05-26 14:03 ` Maciej S. Szmigiero
2015-05-26 14:09 ` Takashi Iwai
2015-05-27 12:04 ` Maciej S. Szmigiero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526094422.GI21577@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=daniel@zonque.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=mreimer@sdgsystems.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox