From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755990AbbEZQ4Y (ORCPT ); Tue, 26 May 2015 12:56:24 -0400 Received: from one.firstfloor.org ([193.170.194.197]:52274 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754822AbbEZQ4T (ORCPT ); Tue, 26 May 2015 12:56:19 -0400 Date: Tue, 26 May 2015 18:56:16 +0200 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , acme@kernel.org, linux-kernel@vger.kernel.org, namhyung@kernel.org, eranian@google.com Subject: Re: Cycles annotation support for perf tools Message-ID: <20150526165616.GN19417@two.firstfloor.org> References: <1431265926-4766-1-git-send-email-andi@firstfloor.org> <20150526100845.GB6555@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150526100845.GB6555@krava.brq.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > columns are displayed fine, but the current highlighted line disappeared > and also and standard annotation (without LBR) is broken.. I can't reproduce that. Everything looks fine to me. Please investigate on your side. That's the only hunk that's changing colors. It looks equivalent to me: @@ -110,11 +122,29 @@ static void annotate_browser__write(struct ui_browser *browser, void *entry, int percent_max = bdl->percent[i]; } - if (dl->offset != -1 && percent_max != 0.0) { - for (i = 0; i < ab->nr_events; i++) { - ui_browser__set_percent_color(browser, bdl->percent[i], - current_entry); - slsmg_printf("%6.2f ", bdl->percent[i]); + if (dl->offset != -1) { + if (percent_max != 0.0) { + for (i = 0; i < ab->nr_events; i++) { + ui_browser__set_percent_color(browser, + bdl->percent[i], + current_entry); + slsmg_printf("%6.2f ", bdl->percent[i]); + } + } else { + slsmg_write_nstring(" ", 7 * ab->nr_events); + } + + if (ab->have_cycles) { + ui_browser__set_color(browser, HE_COLORSET_NORMAL); + if (dl->ipc) + slsmg_printf("%*.2f ", IPC_WIDTH - 1, dl->ipc); + else + slsmg_write_nstring(" ", IPC_WIDTH); + if (dl->cycles) + slsmg_printf("%*" PRIu64 " ", + CYCLES_WIDTH - 1, dl->cycles); + else + slsmg_write_nstring(" ", CYCLES_WIDTH); } } else { ui_browser__set_percent_color(browser, 0, current_entry); -- ak@linux.intel.com -- Speaking for myself only.