Re: [PATCH] usb: ulpi: don't register drivers if bus doesn't exist

Heikki Krogerus
2015-05-22T10:18:59Z

> > >>diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c
> > >>index 0e6f968..0b0a5e7 100644
> > >>--- a/drivers/usb/common/ulpi.c
> > >>+++ b/drivers/usb/common/ulpi.c
> > >>@@ -132,6 +132,10 @@ int ulpi_register_driver(struct ulpi_driver *drv)
> > >> if (!drv->probe)
> > >> return -EINVAL;
> > >>+ /* Was the bus registered successfully? */
> > >>+ if (!ulpi_bus.p)
> > >>+ return -ENODEV;
>
> I think we need to warn in this case. How about:
>
> if (unlikely(WARN_ON(!ulpi_bus.p)))
> return -ENODEV;

I think we should also return -EAGAIN here.

Thanks,

--
heikki