From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Shailendra Verma <shailendra.capricorn@gmail.com>
Cc: Jingoo Han <jg1.han@samsung.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input:mouse:synaptics_i2c - Use bool function return value
Date: Tue, 26 May 2015 14:44:06 -0700 [thread overview]
Message-ID: <20150526214406.GC10343@dtor-ws> (raw)
In-Reply-To: <1432575184-3348-1-git-send-email-shailendra.capricorn@gmail.com>
On Mon, May 25, 2015 at 11:03:04PM +0530, Shailendra Verma wrote:
> The function synaptics_i2c_get_input() has bool return type.
> So use bool value flase instead of 0 to return.
>
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
Folded all 3 patches together and applied.
Thank you.
> ---
> drivers/input/mouse/synaptics_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/mouse/synaptics_i2c.c b/drivers/input/mouse/synaptics_i2c.c
> index 2c87a93..ffceedc 100644
> --- a/drivers/input/mouse/synaptics_i2c.c
> +++ b/drivers/input/mouse/synaptics_i2c.c
> @@ -342,7 +342,7 @@ static bool synaptics_i2c_get_input(struct synaptics_i2c *touch)
>
> /* Deal with spontaneous resets and errors */
> if (synaptics_i2c_check_error(touch->client))
> - return 0;
> + return false;
>
> /* Get Gesture Bit */
> data = synaptics_i2c_reg_get(touch->client, DATA_REG0);
> --
> 1.7.9.5
>
--
Dmitry
prev parent reply other threads:[~2015-05-26 21:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 17:33 [PATCH] Input:mouse:synaptics_i2c - Use bool function return value Shailendra Verma
2015-05-26 21:44 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150526214406.GC10343@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=jg1.han@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shailendra.capricorn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox