From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752272AbbEZVoP (ORCPT ); Tue, 26 May 2015 17:44:15 -0400 Received: from mail-ig0-f178.google.com ([209.85.213.178]:36946 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751478AbbEZVoK (ORCPT ); Tue, 26 May 2015 17:44:10 -0400 Date: Tue, 26 May 2015 14:44:06 -0700 From: Dmitry Torokhov To: Shailendra Verma Cc: Jingoo Han , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input:mouse:synaptics_i2c - Use bool function return value Message-ID: <20150526214406.GC10343@dtor-ws> References: <1432575184-3348-1-git-send-email-shailendra.capricorn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1432575184-3348-1-git-send-email-shailendra.capricorn@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 25, 2015 at 11:03:04PM +0530, Shailendra Verma wrote: > The function synaptics_i2c_get_input() has bool return type. > So use bool value flase instead of 0 to return. > > Signed-off-by: Shailendra Verma Folded all 3 patches together and applied. Thank you. > --- > drivers/input/mouse/synaptics_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/mouse/synaptics_i2c.c b/drivers/input/mouse/synaptics_i2c.c > index 2c87a93..ffceedc 100644 > --- a/drivers/input/mouse/synaptics_i2c.c > +++ b/drivers/input/mouse/synaptics_i2c.c > @@ -342,7 +342,7 @@ static bool synaptics_i2c_get_input(struct synaptics_i2c *touch) > > /* Deal with spontaneous resets and errors */ > if (synaptics_i2c_check_error(touch->client)) > - return 0; > + return false; > > /* Get Gesture Bit */ > data = synaptics_i2c_reg_get(touch->client, DATA_REG0); > -- > 1.7.9.5 > -- Dmitry