From: Greg KH <gregkh@linuxfoundation.org>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Tal Shorer <tal.shorer@gmail.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Sasha Levin <sasha.levin@oracle.com>,
USB list <linux-usb@vger.kernel.org>,
"<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>,
David Cohen <david.a.cohen@linux.intel.com>,
Felipe Balbi <balbi@ti.com>, Lu Baolu <baolu.lu@linux.intel.com>
Subject: Re: [PATCH] usb: ulpi: don't register drivers if bus doesn't exist
Date: Tue, 26 May 2015 19:39:44 -0700 [thread overview]
Message-ID: <20150527023944.GC7038@kroah.com> (raw)
In-Reply-To: <87a8wsoan6.fsf@nemi.mork.no>
On Mon, May 25, 2015 at 07:00:13PM +0200, Bjørn Mork wrote:
> Greg KH <gregkh@linuxfoundation.org> writes:
>
> > If there are other bus drivers that do this, I'll go fix them up,
> > pointers to those files would be appreciated.
>
> git grep -E 'if .*\.p\W' found a couple of interesting candidates you
> might want to check out:
>
> drivers/i2c/i2c-core.c: if (unlikely(WARN_ON(!i2c_bus_type.p))) {
> drivers/i2c/i2c-core.c: if (unlikely(WARN_ON(!i2c_bus_type.p)))
> drivers/spmi/spmi.c: if (WARN_ON(!spmi_bus_type.p))
>
> And this looks somewhat suspicious too, but could very well be OK for
> all I know (very close to nothing :)
>
> drivers/gpio/gpiolib-sysfs.c: if (!gpio_class.p) {
> drivers/gpio/gpiolib-sysfs.c: if (!gpio_class.p)
Thanks, when I get a chance I'll look into this...
greg k-h
next prev parent reply other threads:[~2015-05-27 2:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 19:33 [PATCH] usb: ulpi: don't register drivers if bus doesn't exist Sasha Levin
2015-05-20 21:22 ` David Cohen
2015-05-21 6:39 ` Lu, Baolu
2015-05-21 7:21 ` Heikki Krogerus
2015-05-22 10:16 ` Heikki Krogerus
2015-05-22 10:52 ` Heikki Krogerus
2015-05-22 14:21 ` Sasha Levin
2015-05-24 7:19 ` Greg KH
2015-05-24 8:09 ` Sudip Mukherjee
2015-05-24 14:30 ` Tal Shorer
2015-05-25 11:40 ` Heikki Krogerus
2015-05-25 16:13 ` Greg KH
2015-05-25 17:00 ` Bjørn Mork
2015-05-26 17:54 ` David Cohen
2015-05-27 2:41 ` Greg KH
2015-05-27 4:35 ` Sudip Mukherjee
2015-05-27 16:49 ` David Cohen
2015-05-27 2:39 ` Greg KH [this message]
2015-05-27 8:39 ` Heikki Krogerus
2015-05-27 9:05 ` Sudip Mukherjee
2015-05-27 15:16 ` Alan Stern
2015-05-27 15:21 ` Greg KH
2015-05-28 5:39 ` Sudip Mukherjee
2015-05-28 5:54 ` Felipe Balbi
2015-05-28 6:42 ` Sudip Mukherjee
2015-05-28 6:53 ` Sudip Mukherjee
2015-05-28 15:57 ` Alan Stern
2015-05-28 12:36 ` Sasha Levin
2015-05-28 13:24 ` Heikki Krogerus
2015-05-28 16:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527023944.GC7038@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=balbi@ti.com \
--cc=baolu.lu@linux.intel.com \
--cc=bjorn@mork.no \
--cc=david.a.cohen@linux.intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=tal.shorer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox