From: Greg KH <gregkh@linuxfoundation.org>
To: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, xinhuix.pan@intel.com,
alan@linux.intel.com
Subject: Re: [PATCH V2 3/3] n_gsm: wake up ldisc tty before using it
Date: Tue, 26 May 2015 20:02:12 -0700 [thread overview]
Message-ID: <20150527030212.GB9124@kroah.com> (raw)
In-Reply-To: <556530D9.5060506@linux.intel.com>
On Wed, May 27, 2015 at 10:50:01AM +0800, Zhang, Yanmin wrote:
> Wake up ldisc device before calling its driver to access the device.
>
> Signed-off-by: Zhang Yanmin <yanmin.zhang@intel.com>
>
> ---
>
> drivers/tty/n_gsm.c | 40 +++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 39 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
> index 2c34c32..40671fa 100644
> --- a/drivers/tty/n_gsm.c
> +++ b/drivers/tty/n_gsm.c
> @@ -62,6 +62,7 @@
> #include <linux/netdevice.h>
> #include <linux/etherdevice.h>
> #include <linux/gsmmux.h>
> +#include <linux/pm_runtime.h>
>
> static int debug;
> module_param(debug, int, 0600);
> @@ -555,6 +556,27 @@ static int gsm_stuff_frame(const u8 *input, u8 *output, int len)
> return olen;
> }
>
> +static int pm_runtime_get_sync_tty(struct tty_struct *tty)
> +{
> + int ret = 0;
> +
> + /*Wakeup parent as tty itself doesn't enable runtime*/
No spaces in your comment?
Anyway, this is corrupted and can't be applied, please fix up your email
client and try it again...
greg k-h
next prev parent reply other threads:[~2015-05-27 3:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 2:50 [PATCH V2 3/3] n_gsm: wake up ldisc tty before using it Zhang, Yanmin
2015-05-27 3:02 ` Greg KH [this message]
2015-05-27 3:43 ` Zhang, Yanmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150527030212.GB9124@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xinhuix.pan@intel.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox