Re: CPU LED trigger: add hooks to generic code so that it works on x86

Peter Zijlstra
2015-05-27T08:08:47Z

On Wed, May 27, 2015 at 09:47:57AM +0200, Pavel Machek wrote:
> On Wed 2015-05-27 09:43:43, Peter Zijlstra wrote:
> > On Wed, May 27, 2015 at 08:57:12AM +0200, Pavel Machek wrote:
> > >
> > > CPU LED trigger hooks are currently hidden in arm-specific code, which
> > > means that this trigger only works on arm. Add it to the generic
> > > code, so that it works on x86, too.
> >
> > And why do we want to go and slow down the idle loop for everyone?
>
> If the trigger is not configured, this is not slowing down anyone.
>
> If the trigger is configured, well, then the user requested the
> functionality. So we are not slowing down _everyone_, just the people
> that want the blinking.

What kind of x86 hardware will support this? If its _everything_ distros
will have to enable this and it suddenly becomes a lot of people.