Re: CPU LED trigger: add hooks to generic code so that it works on x86

Peter Zijlstra
2015-05-27T12:17:34Z

On Wed, May 27, 2015 at 10:47:18AM +0200, Pavel Machek wrote:
>
> Distros should not enable this, IMO. But I don't think overhead is
> that big in either case.

Coming back from idle there might not be any cache, and you're adding at
least 1 more cache miss for loading cpu_trig -- those hurt. Looking at
that code, in case of !trig, you do a pointless function call before
bailing.

The thing is, there already is too much code in the wake from idle path,
adding more is not my favourite thing.

One thing you could do is wrap the call to ledtrig_cpu() in a
static_key, that way all we do is add some i$ pollution, but at least we
avoid the data cache miss when there's nothing to do.